Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

truvari:1.3.2->1.3.4 #81177

Merged
merged 1 commit into from Mar 2, 2020
Merged

truvari:1.3.2->1.3.4 #81177

merged 1 commit into from Mar 2, 2020

Conversation

scalavision
Copy link
Contributor

@scalavision scalavision commented Feb 27, 2020 •
edited

Motivation for this change

upgrade because of a bug in 1.3.2.

Things done
  • [ x] Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • [x ] NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [x ] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • [x ] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • [ x] Ensured that relevant documentation is up to date
  • [ x] Fits CONTRIBUTING.md.

I have tested this locally and everything works.

@KoviRobi
Copy link
Contributor

KoviRobi commented Mar 1, 2020 •
edited

I have some other potential changes in
https://github.com/KoviRobi/nixpkgs/tree/zhf-20.03-fix-truvari

Which is tied to ZHF #80379

One change is that it might be better to ask the application developer if it's better to have exact versions, or not -- which is what I have done and it lead to an upstream patch so we won't have to have ad-hoc patches on it in the future (currently I pull in just the patch, but this won't be necessary for later versions) :)

The other is (and I am not sure on the official stance on this), it might be better to use python3.pkgs.callPackage (which I believe is the same as python3Packages.callPackage)

@FRidh FRidh merged commit dbb4826 into NixOS:master Mar 2, 2020
@FRidh
Copy link
Member

FRidh commented Mar 2, 2020

cherry-picked to 20.03 as 06e9970

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scalavision @KoviRobi @FRidh