Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] indicator-cpufreq: init at bzr 98 #81174

Closed
wants to merge 1 commit into from
Closed

[wip] indicator-cpufreq: init at bzr 98 #81174

wants to merge 1 commit into from

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Feb 27, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I need some help here, need to fix a cadence dependencies ( see improvement here #81098 )
Issues :

  • dbus.exceptions.DBusException: org.freedesktop.DBus.Error.AccessDenied: Connection ":1.400" is not allowed to own the service "com.ubuntu.IndicatorCpufreqSelector" due to security policies in the configuration file

@worldofpeace
Copy link
Contributor

This appears to be one of those ubuntu appindicators?
It appears to be abandoned from the activity https://code.launchpad.net/indicator-cpufreq, and there's no response to bug reports https://bugs.launchpad.net/indicator-cpufreq. I don't think this belongs in nixpkgs, and we have a fairly low spread in other distros https://repology.org/project/indicator-cpufreq/versions.

@worldofpeace
Copy link
Contributor

I believe this dbus conf is a security vulnerability

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE busconfig PUBLIC "-//freedesktop//DTD D-BUS Bus Configuration 1.0//EN"
"http://www.freedesktop.org/standards/dbus/1.0/busconfig.dtd">
 <!-- To the extent possible under law, David D. Lowe has waived all 
 copyright and related or neighboring rights to this file.
 License: http://creativecommons.org/publicdomain/zero/1.0/ -->
<busconfig>
  <type>system</type>
  <!-- Only root can own the service -->
  <policy user="root">
    <allow own="com.ubuntu.IndicatorCpufreqSelector"/>
    <allow send_interface="com.ubuntu.IndicatorCpufreqSelector"/>
  </policy>

  <!-- Allow anyone to invoke methods on the interfaces -->
  <policy context="default">
    <allow send_interface="com.ubuntu.IndicatorCpufreqSelector"/>
  </policy>
</busconfig>

The comment at the beginning is false. everybody is allowed to own the
service on the D-Bus system bus.

@worldofpeace
Copy link
Contributor

I'm going to close this, because I believe it's unsafe to have this in nixpkgs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bignaux @worldofpeace