Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vaultenv: 0.8.0 -> 0.13.0 #81165

Merged
merged 1 commit into from Feb 27, 2020
Merged

vaultenv: 0.8.0 -> 0.13.0 #81165

merged 1 commit into from Feb 27, 2020

Conversation

manveru
Copy link
Contributor

@manveru manveru commented Feb 27, 2020 •
edited

Motivation for this change

This package was marked as broken and pretty old. Updated to latest and added the missing dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LnL7

LnL7
LnL7 approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit c6bbad4 into NixOS:master Feb 27, 2020
@cdepillabout
Copy link
Member

Just a heads-up: in the last week or so, the haskell-updates branch has updated to lts-15 (ghc-8.8.2).

I believe this update has broken vaultenv again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@manveru @cdepillabout @LnL7