Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.digital-ocean: 1.13.2 -> 1.15.0 #81217

Merged
merged 1 commit into from Mar 3, 2020
Merged

pythonPackages.digital-ocean: 1.13.2 -> 1.15.0 #81217

merged 1 commit into from Mar 3, 2020

Conversation

Kiwi
Copy link
Member

@Kiwi Kiwi commented Feb 27, 2020 •
edited

updated to newest version (1.13.2 was released ~2.25 years ago). switched to fetchFromGitHub to enable tests. added kiwi to maintainers. formatted with nixpkgs-fmt

Motivation for this change

it was old. and i think i need it updated for work i want to do on https://github.com/Kiwi/nixops-digitalocean/tree/digitalocean

Things done

i tested it (the python2Packages one at least) with my nixops-digitalocean successfully and the tests are now enabled and pass for both python2Packages and python3Packages. doing a nixpkgs-review pr 81217 right now... it might take a while.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from teh February 27, 2020 23:29
jonringer
jonringer approved these changes Feb 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[7 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81217
6 package built:
nixops nixopsUnstable nixops_1_6_1 python27Packages.digital-ocean python37Packages.digital-ocean python38Packages.digital-ocean

@jonringer
Copy link
Contributor

@GrahamcOfBorg build nixops nixopsUnstable nixops_1_6_1 python27Packages.digital-ocean python37Packages.digital-ocean python38Packages.digital-ocean

@worldofpeace
Copy link
Contributor

This PR should be good after that final comment is applied.

@Kiwi
pythonPackages.digital-ocean: 1.13.2 -> 1.15.0
8653b7a 
updated to newest version (1.13.2 was released ~2.25 years ago). switched to fetchFromGitHub to enable tests. added kiwi to maintainers. formatted with nixpkgs-fmt
@Kiwi Kiwi force-pushed the python-digitalocean-1.15.0 branch from d41a145 to 8653b7a Compare March 3, 2020 02:19
@worldofpeace worldofpeace merged commit 539706c into NixOS:master Mar 3, 2020
@worldofpeace
Copy link
Contributor

Thank you @Kiwi

@Kiwi Kiwi deleted the python-digitalocean-1.15.0 branch March 3, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@worldofpeace worldofpeace worldofpeace requested changes

@FRidh FRidh Awaiting requested review from FRidh

@teh teh Awaiting requested review from teh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Kiwi @jonringer @worldofpeace