stdenv: Fix gcc multi line libc-cflags #81191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Instead of processing the file with tr we could instead replace "echo" with "echo -n" |
|
Either seems OK to me and very unlikely to break anything. I can confirm this PR fixes the broken |
orivej
approved these changes
Feb 28, 2020
clkamp
force-pushed
the
stdenv-multi-line-libc-cflags
branch
from
202175c
to
bc57a4d
Compare
Ericson2314
reviewed
Mar 6, 2020
which broke at least libstdc++5. Closes NixOS#79761
clkamp
force-pushed
the
stdenv-multi-line-libc-cflags
branch
from
bc57a4d
to
80729b6
Compare
rvem
pushed a commit
to serokell/nixpkgs
that referenced
this pull request
Nov 8, 2022
Regression introduced in PR NixOS#81191 80729b6. The file does not exist somewhere during bootstrap of pkgsStatic.busybox which is used in nix (by default). I tested the builds.
rvem
pushed a commit
to serokell/nixpkgs
that referenced
this pull request
Nov 8, 2022
Regression introduced in PR NixOS#81191 80729b6. The file does not exist somewhere during bootstrap of pkgsStatic.busybox which is used in nix (by default). I tested the builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Multiple lines in libc-cflags were introduced in 162a935
Closes #79761
Things done
I tested only the cc-wrapper because of the large number of recompiles. But I have checked, that this realy fixes #79761 by applying the concatenation to the reading cat'ing of libc-cflags in there.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)