Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yubiaoth-desktop: 4.3.6 -> 5.0.2 #81162

Merged
merged 2 commits into from Feb 27, 2020
Merged

yubiaoth-desktop: 4.3.6 -> 5.0.2 #81162

merged 2 commits into from Feb 27, 2020

Conversation

rissson
Copy link
Member

@rissson rissson commented Feb 27, 2020 •
edited

Motivation for this change

Upgrading this packages to next major version adding a new UI and more features.

I also added myself as a maintainer for this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc. @Mic92

@ofborg ofborg bot requested a review from Mic92 February 27, 2020 06:19
cole-h
cole-h approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't have a Yubikey to test functionality, but it launches, and the UI is interactive.

[3 built, 19 copied (12.4 MiB), 2.6 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81162
1 package built:
yubioath-desktop

@Mic92 Mic92 merged commit aa0b692 into NixOS:master Feb 27, 2020
@rissson rissson mentioned this pull request Mar 10, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rissson @cole-h @Mic92