Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faust2jaqt: make it work again #81301

Closed
wants to merge 1 commit into from

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Feb 28, 2020

My update from 2.5.23 to 2.20.2 broke this pkg, this commit fixes it.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pvgoran
Copy link
Contributor

pvgoran commented Mar 1, 2020

Doing random review.

For me, this package's binaries don't work at all, in all versions that I checked (release-19.09, master, and this PR). Here is what I see in all cases:

> faust2jaqt
which: no qmake-qt5 in (... a long list of directories ...)
which: no qmake-qt4 in (... a long list of directories ...)

However, if I try to run faust2jaqt in a pure nix-shell environment, the result is different.

In release-19.09:

$ faust2jaqt 
/nix/store/ysqw6aqgxc61albr5j3papksnjcdp3hb-faust2jaqt-2.5.23/bin/.faust2jaqt-wrapped: line 39: which: command not found
/nix/store/ysqw6aqgxc61albr5j3papksnjcdp3hb-faust2jaqt-2.5.23/bin/.faust2jaqt-wrapped: line 39: which: command not found

In master:

$ faust2jaqt 
sh: which: command not found
sh: which: command not found
sh: which: command not found
/nix/store/i8v9bask59xs22sfgv882414lc6psyyd-faust2jaqt-2.20.2/bin/.faust2jaqt-wrapped: line 29: which: command not found
/nix/store/i8v9bask59xs22sfgv882414lc6psyyd-faust2jaqt-2.20.2/bin/.faust2jaqt-wrapped: line 29: which: command not found

With this PR:

$ faust2jaqt
which: no qmake-qt5 in (... a long list of directories ...)
which: no qmake-qt4 in (... a long list of directories ...)

@magnetophon
Copy link
Member Author

@pvgoran Thanks for the review!

These faust scripts are all compilers, so they need a file to compile:

touch tst.dsp
echo "process = +;" > tst.dsp
faust2jack tst.dsp
./tst

Note that I used faust2jack and not faust2jaqt since for some of these scripts there is, as you noted, a difference between running them in nix shell or not, see #78610

To test faust2jaqt, you need to run it from inside a suitable nix-shell.
I use

nix-shell --command zsh $NIXPKGS -A magnetophonDSP.faustCompressors

but guess/hope you found a simpler and more generic command; I'm quite new to nix-shell.
What did you use to get in a suitable shell?

@magnetophon
Copy link
Member Author

magnetophon commented Mar 3, 2020

The latest faust release has a bug, causing it not being able to compile a lot of code.
This fixes that.

@magnetophon
Copy link
Member Author

Closed in favour of these PR's, which have more granular commits with better messages:
#82650
#82652

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants