Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pypy{,3}: use openssl_1_1 #81300

Merged
merged 1 commit into from Feb 29, 2020
Merged

pypy{,3}: use openssl_1_1 #81300

merged 1 commit into from Feb 29, 2020

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Feb 28, 2020 •
edited

Motivation for this change

Per #80746.

"We now support building PyPy with OpenSSL 1.1 in our built-in _ssl
module, as well as maintaining support for previous versions."
-- https://pypy.readthedocs.io/en/latest/release-pypy2.7-v5.6.0.html

@GrahamcOfBorg build pypy pypy3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@emilazy
pypy{,3}: use openssl_1_1
6d3fc35 
"We now support building PyPy with OpenSSL 1.1 in our built-in _ssl
module, as well as maintaining support for previous versions."
-- https://pypy.readthedocs.io/en/latest/release-pypy2.7-v5.6.0.html
@emilazy emilazy changed the title pypy: use openssl_1_1 pypy{,3}: use openssl_1_1 Feb 28, 2020
@ofborg ofborg bot requested a review from andersk February 28, 2020 16:15
@vcunat vcunat added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 28, 2020
@emilazy
Copy link
Member Author

emilazy commented Feb 28, 2020

@GrahamcOfBorg build pypy pypy3

@emilazy
Copy link
Member Author

emilazy commented Feb 28, 2020

Well, it timed out on ofborg, but I've verified that pypy{,3} build, so this should be about ready for merging.

@emilazy emilazy marked this pull request as ready for review February 28, 2020 18:12
@emilazy emilazy requested a review from FRidh as a code owner February 28, 2020 18:12
@emilazy emilazy mentioned this pull request Feb 28, 2020
Merged
10 tasks
@vcunat
Copy link
Member

vcunat commented Feb 28, 2020

They build for me locally. I can try something else as well, if it's easy to do.

@emilazy
Copy link
Member Author

emilazy commented Feb 28, 2020

Not sure about good stress tests for PyPy in general, but building nextpnr should exercise it a a fair bit through use of icestorm; those are the packages I maintain so they're what prompted this update.

@vcunat
Copy link
Member

vcunat commented Feb 28, 2020

nextpnr also built for me, neko-san. I suppose I won't merge yet to give others some time to react?

@worldofpeace worldofpeace merged commit d944851 into NixOS:master Feb 29, 2020
@emilazy emilazy deleted the fix-pypy-openssl branch February 29, 2020 01:21
@vcunat vcunat removed the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andersk andersk andersk approved these changes

@FRidh FRidh FRidh approved these changes

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@emilazy @vcunat @andersk @FRidh @worldofpeace