Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tealdeer: 1.2.0 -> 1.3.0 #81226

Merged
merged 1 commit into from Mar 4, 2020
Merged

tealdeer: 1.2.0 -> 1.3.0 #81226

merged 1 commit into from Mar 4, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 28, 2020

https://github.com/dbrgn/tealdeer/blob/master/CHANGELOG.md#v130-2020-02-28

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dywedir
Copy link
Member

dywedir commented Feb 28, 2020

@GrahamcOfBorg build tealdeer

@zowoq zowoq mentioned this pull request Feb 28, 2020
10 tasks
@evanjs
Copy link
Member

evanjs commented Feb 28, 2020

Seems to compile fine here, thanks!

Unfortunately, though, tldr --update still doesn't seem to work for me. Am I alone here?
Works fine in the test environment, but not on my actual system.

Note that this was happening before this PR.

@dbrgn
Copy link
Contributor

dbrgn commented Feb 28, 2020

Unfortunately, though, tldr --update still doesn't seem to work for me. Am I alone here?

Could you build tealdeer with --features logging and then run with RUST_LOG=debug?

@evanjs
Copy link
Member

evanjs commented Feb 28, 2020

Unfortunately, though, tldr --update still doesn't seem to work for me. Am I alone here?

Could you build tealdeer with --features logging and then run with RUST_LOG=debug?

In trying to do so, I realized I must've mis-tested this 😵

nix-env -f nixpkgs -iA tealdeer from inside the nixpkgs-review shell and tldr --update (from my normal system env) seems to work fine, now.

On another note, any idea if there's a reason we don't ship crates with logging features by default?
I'd imagine it might be partly due to common feature flag names differing between crates, but 🤷‍♂️

@dbrgn
Copy link
Contributor

dbrgn commented Feb 28, 2020

if there's a reason we don't ship crates with logging features by default

The logging feature is custom to tealdeer, most people won't need it and without it there are less dependencies and the binary is a bit smaller. However, it wouldn't hurt to enable it in nix either.

@marsam marsam merged commit 6c5b730 into NixOS:master Mar 4, 2020
@marsam
Copy link
Contributor

marsam commented Mar 4, 2020

However, it wouldn't hurt to enable it in nix either

please feel free to open another PR for the logging feature

@zowoq zowoq deleted the tealdeer branch March 4, 2020 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants