Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/sslh: don't run as nogroup #81297

Merged
merged 1 commit into from Mar 1, 2020
Merged

nixos/sslh: don't run as nogroup #81297

merged 1 commit into from Mar 1, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 28, 2020 •
edited

See #55370

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
Copy link
Member

I expected that DynamicUser would mess with iptables's --uid-owner (used in transparent mode) but it seems that it still works.
I put this PR on top of #77982 and the test still passes.

@pvgoran
Copy link
Contributor

pvgoran commented Mar 1, 2020

Doing random review.

After loading the updated module, the service sslh seems to work as expected: I'm able to connect to SSH via port 443. Also, I can see that the service now runs under group sslh:

> pgrep sslh | xargs ps -o user,group
USER     GROUP
sslh     sslh
sslh     sslh

@Mic92 Mic92 merged commit 1b92a08 into NixOS:master Mar 1, 2020
@Mic92 Mic92 deleted the sslh branch March 1, 2020 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @symphorien @pvgoran