Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teensyduino: add missing dependencies for teensy-loader #81156

Merged
merged 1 commit into from Mar 7, 2020
Merged

teensyduino: add missing dependencies for teensy-loader #81156

merged 1 commit into from Mar 7, 2020

Conversation

rehno-lindeque
Copy link
Contributor

Motivation for this change

This is a fixed version of #75560 that adds the missing package arguments (cairo and udev) at the top of the file.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from bjornfor and bergey February 27, 2020 01:53
bjornfor
bjornfor requested changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but I would like to see the commit message have the "teensyduino:" prefix.

@rehno-lindeque rehno-lindeque changed the title add missing dependencies for teensy-loader teensyduino: add missing dependencies for teensy-loader Mar 6, 2020
@rehno-lindeque
Copy link
Contributor Author

rehno-lindeque commented Mar 6, 2020 •
edited

Sorry about forgetting that, I've added teensyduino: to the commit message now and rebased on master.

@ofborg ofborg bot requested a review from bjornfor March 6, 2020 23:28
@bjornfor bjornfor merged commit b13f878 into NixOS:master Mar 7, 2020
This was referenced Mar 10, 2020
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@bergey bergey Awaiting requested review from bergey

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rehno-lindeque @bjornfor