Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.somajo: init at 2.0.4 #81279

Merged
merged 1 commit into from Mar 14, 2020
Merged

python3Packages.somajo: init at 2.0.4 #81279

merged 1 commit into from Mar 14, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

SoMaJo is a tokenizer for German and English web text and is quite popular in the German NLP community. Including this package is very low-impact, since it only relies on the Python regex package.

The sources are retrieved from GitHub (rather than PyPI), so that we can run its test suite.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Feb 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the python38 tests seem to hang, not sure if upstream is aware

@danieldk
Copy link
Contributor Author

the python38 tests seem to hang, not sure if upstream is aware

Strange! Works without issues on my machine (with sandboxing).

@jonringer
Copy link
Contributor

hmm, the other two completed in 1-2 minutes, killed python38 after 10

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.somajo python38Packages.somajo

@jonringer
Copy link
Contributor

if ofborg can build it, then I'm okay with it

@danieldk danieldk changed the title python3Packages.somajo: init at 2.0.3 python3Packages.somajo: init at 2.0.4 Mar 6, 2020
@danieldk
Copy link
Contributor Author

danieldk commented Mar 6, 2020

Updated to 2.0.4. @jonringer , this version fixes a race condition tsproisl/SoMaJo@fa67aa7 , maybe this was the hang that you ran into?

@jonringer
Copy link
Contributor

could have been

jonringer
jonringer approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
commit LGTM
has test 👍

[4 built, 1 copied (1.3 MiB), 0.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81279
2 package built:
python37Packages.somajo python38Packages.somajo

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.somajo python38Packages.somajo

@FRidh FRidh merged commit e539eb9 into NixOS:master Mar 14, 2020
@danieldk danieldk deleted the somajo-2.0.3 branch July 6, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @jonringer @FRidh