Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.sapi-python-client: init at 0.13.1 #81184

Merged
merged 3 commits into from Mar 5, 2020
Merged

python3Packages.sapi-python-client: init at 0.13.1 #81184

merged 3 commits into from Mar 5, 2020

Conversation

MrMebelMan
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@MrMebelMan
Copy link
Contributor Author

Updated as per review comments, but now there's error I can't figure out...

LookupError: setuptools-scm was unable to detect version for '/build/source'.

Make sure you're either building from a fully intact git repository or PyPI tarballs. Most other sources (such as GitHub's tarballs, a git checkout without the .git folder) don't contain the necessary metadata and will not work.

For example, if you're using pip, instead of https://github.com/user/proj/archive/master.zip use git+https://github.com/user/proj.git#egg=proj

@mmahut
Copy link
Member

mmahut commented Mar 3, 2020

Maybe try something like:

nixpkgs/pkgs/development/python-modules/measurement/default.nix

Line 18 in eed30df

sed -i 's|use_scm_version=True|version="${version}"|' setup.py

@MrMebelMan
Copy link
Contributor Author

Maybe try something like:

nixpkgs/pkgs/development/python-modules/measurement/default.nix

Line 18 in eed30df

sed -i 's|use_scm_version=True|version="${version}"|' setup.py

Oh 👀
Thanks!

@MrMebelMan
Copy link
Contributor Author

Rebased master.

@mmahut
Copy link
Member

mmahut commented Mar 3, 2020

@GrahamcOfBorg build python3Packages.sapi-python-client

@mmahut mmahut merged commit 05ee889 into NixOS:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrMebelMan @mmahut @jonringer