Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prometheus-nginx-exporter: 0.5.0 -> 0.6.0 #81285

Merged
merged 2 commits into from Mar 2, 2020
Merged

prometheus-nginx-exporter: 0.5.0 -> 0.6.0 #81285

merged 2 commits into from Mar 2, 2020

Conversation

WilliButz
Copy link
Member

Motivation for this change

https://github.com/nginxinc/nginx-prometheus-exporter/releases/tag/v0.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz
prometheus-nginx-exporter: 0.5.0 -> 0.6.0
99a1630
@WilliButz
nixos/prometheus-nginx-exporter: update for 0.6.0
027f405 
Added new option constLabels and updated virtualHost name in the
exporter's test.
@WilliButz
Copy link
Member Author

@GrahamcOfBorg test prometheus-exporters.nginx

@ofborg ofborg bot requested review from ehmry, benley, globin and fpletz February 28, 2020 12:07
@Frostman
Copy link
Member

Frostman commented Mar 2, 2020

nixpkgs-review passed, binary works okay (x86_64)

@benley
Copy link
Member

benley commented Mar 2, 2020

Does the service still work properly if constLabels is left empty?

@benley
Copy link
Member

benley commented Mar 2, 2020

(it looks like the answer is probably yes but I'm too sleepy to verify myself right now)

@benley benley merged commit eaef960 into NixOS:master Mar 2, 2020
@WilliButz WilliButz deleted the update-nginx-exporter branch March 6, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

@benley benley Awaiting requested review from benley

@globin globin Awaiting requested review from globin

@fpletz fpletz Awaiting requested review from fpletz

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @Frostman @benley