Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kompose: 1.20.0 -> 1.21.0 #81181

Merged
merged 1 commit into from Feb 28, 2020
Merged

kompose: 1.20.0 -> 1.21.0 #81181

merged 1 commit into from Feb 28, 2020

Conversation

zowoq
Copy link
Contributor

@zowoq zowoq commented Feb 27, 2020

https://github.com/kubernetes/kompose/releases/tag/v1.21.0

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from ehmry, vdemeester and thpham February 27, 2020 13:44
@vdemeester
Copy link
Member

@GrahamcOfBorg build kompose

vdemeester
vdemeester approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@marsam marsam merged commit e11c716 into NixOS:master Feb 28, 2020
@marsam
Copy link
Contributor

marsam commented Feb 28, 2020

Thanks!

@zowoq zowoq deleted the kompose branch February 28, 2020 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdemeester vdemeester vdemeester approved these changes

@ehmry ehmry Awaiting requested review from ehmry

@thpham thpham Awaiting requested review from thpham

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zowoq @vdemeester @marsam