Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixops-aws
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 90ed3a3bd2a0
Choose a base ref
...
head repository: NixOS/nixops-aws
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: f49ab5d49fbe
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Feb 28, 2020

  1. iam_role.destroy(): handle resources that are already removed

    @AmineChikhaoui
    AmineChikhaoui committed Feb 28, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    f49ab5d View commit details
Showing with 11 additions and 0 deletions.
  1. +11 −0 nixopsaws/resources/iam_role.py
11 changes: 11 additions & 0 deletions nixopsaws/resources/iam_role.py
View file
Original file line number Diff line number Diff line change
@@ -112,6 +112,9 @@ def _destroy(self):
raise
except IamNotFound:
self.warn("role policy already destroyed")
except BotoServerError as e:
if e.status == 404:
self.warn("role policy already removed")
except Exception as e:
self.log("error removing role policy: " + str(e))
raise
@@ -124,6 +127,10 @@ def _destroy(self):
raise
except IamNotFound:
self.warn("could not find role")
except BotoServerError as e:
if e.status == 404:
self.warn("role already removed")

except Exception as e:
self.log("error removing role: " + str(e))
raise
@@ -135,6 +142,10 @@ def _destroy(self):
raise
except IamNotFound:
self.warn("instance profile already destroyed");
except BotoServerError as e:
if e.status == 404:
self.warn("instance profile already removed")

except Exception as e:
self.log(str(e))
raise