Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

knot-resolver: fix cpu usage in kres-gc-cache #81188

Closed
wants to merge 1 commit into from
Closed

knot-resolver: fix cpu usage in kres-gc-cache #81188

wants to merge 1 commit into from

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 27, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Feb 27, 2020 •
edited

@vcunat ping me when the fix hits the knot-resolver repository.

@vcunat vcunat self-assigned this Feb 27, 2020
@vcunat
Copy link
Member

vcunat commented Feb 27, 2020

Note for others: so far noticeable issues have only been confirmed for encrypted ZFS, not for what I'd call "usual configurations".

@ofborg ofborg bot requested a review from vcunat February 27, 2020 16:46
@vcunat vcunat closed this in b7f5450 Mar 4, 2020
@vcunat
Copy link
Member

vcunat commented Mar 4, 2020

I'm not sure about 20.03. I didn't push anything in there (for now, at least).

@grahamc
Copy link
Member

grahamc commented Mar 4, 2020

Probably should backport, imo.

@Mic92 Mic92 deleted the kresd branch March 4, 2020 12:59
@Mic92
Copy link
Member Author

Mic92 commented Mar 4, 2020

Agreed.

@vcunat
Copy link
Member

vcunat commented Mar 4, 2020

I normally backport minor releases of knot-resolver, so this would probably get in anyway. The change is (slightly?) beneficial to all users that have the cache on a non-tmpfs, not just ZFS.

vcunat added a commit that referenced this pull request Mar 4, 2020
@vcunat
knot-resolver: apply upstream patch
feaa634 
Encrypted ZFS users were affected, in particular some NixOS users
who reported the issue upstream.  /cc #81188.

(cherry picked from commit b7f5450)
@vcunat
Copy link
Member

vcunat commented Mar 4, 2020

Pushed to 20.03 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat Awaiting requested review from vcunat

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Mic92 @vcunat @grahamc