Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.bravado-core: init at 5.16.1 #81186

Merged
merged 1 commit into from Mar 13, 2020
Merged

pythonPackages.bravado-core: init at 5.16.1 #81186

merged 1 commit into from Mar 13, 2020

Conversation

vanschelven
Copy link
Contributor

Motivation for this change

Bravado is a python client library for Swagger 2.0 services

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Feb 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

[5 built, 15 copied (1.5 MiB), 0.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/81186
3 package built:
python27Packages.bravado-core python37Packages.bravado-core python38Packages.bravado-core

pkgs/development/python-modules/bravado-core/default.nix Outdated Show resolved Hide resolved
@jonringer jonringer merged commit 8b04f24 into NixOS:master Mar 13, 2020
@jonringer
Copy link
Contributor 

https://github.com/NixOS/nixpkgs/pull/81186
3 package built:
python27Packages.bravado-core python37Packages.bravado-core python38Packages.bravado-core```

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@vanschelven @jonringer