Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qcad: init at v3.24.2.1 #81209

Merged
merged 3 commits into from Apr 7, 2020
Merged

qcad: init at v3.24.2.1 #81209

merged 3 commits into from Apr 7, 2020

Conversation

yvesf
Copy link
Member

@yvesf yvesf commented Feb 27, 2020

Motivation for this change

Provide packaging for qcad

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Mar 29, 2020

build is failing

@yvesf
Copy link
Member Author

yvesf commented Mar 29, 2020

@FRidh thanks for your comment. I think I fixed this.

zimbatm
zimbatm reviewed Apr 7, 2020
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Just left a few comments

pkgs/applications/misc/qcad/default.nix
rev = version;
sha256 = "1g295gljq051x09f4d8k586bkg3vs8z22dn3rxj6xrm6803z8zw2";
};

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am no qt packaging expert but I think that something like that is needed as well:

Suggested change
nativeBuildInputs = [ qt5.wrapQtAppsHook ];

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retracting that comment. It looks like it's already wrapped

pkgs/applications/misc/qcad/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/qcad/default.nix Outdated Show resolved Hide resolved
pkgs/applications/misc/qcad/default.nix
pkgconfig
qt5.qmake
qt5.qttools
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general the build inputs are located after the src attribute because they are used in subsequent steps. FYI

@zimbatm zimbatm merged commit 25c3d0d into NixOS:master Apr 7, 2020
@zimbatm
Copy link
Member

zimbatm commented Apr 7, 2020

thanks for your first contribution!

github-actions bot added a commit to utdemir/dotfiles-nix that referenced this pull request Apr 9, 2020
@github-actions
niv nixpkgs: update 9d0c5608 -> 2f41064d
1c909f9 
Dependencies updates.

## Changelog for nixpkgs:
Commits: [NixOS/nixpkgs@9d0c5608...2f41064d](NixOS/nixpkgs@9d0c560...2f41064)

* [`71b1be33`](NixOS/nixpkgs@71b1be3) python3Packages.ftfy: Fix dependencies
* [`6e92198f`](NixOS/nixpkgs@6e92198) python27Packages.pyroute2: 0.5.10 -> 0.5.11
* [`08c7b818`](NixOS/nixpkgs@08c7b81) python37Packages.pytest-html: 2.1.0 -> 2.1.1
* [`83f827cb`](NixOS/nixpkgs@83f827c) k3s: remove extra buildInputs
* [`617fa430`](NixOS/nixpkgs@617fa43) k3s: update maintainers, per pr comment
* [`5040cd56`](NixOS/nixpkgs@5040cd5) atari800: 4.0.0 -> 4.2.0
* [`74caf987`](NixOS/nixpkgs@74caf98) python27Packages.pony: 0.7.12 -> 0.7.13
* [`cf3328e7`](NixOS/nixpkgs@cf3328e) treewide: use runtimeShell in nixos/
* [`50a535c5`](NixOS/nixpkgs@50a535c) python37Packages.moviepy: 1.0.1 -> 1.0.2
* [`926a875d`](NixOS/nixpkgs@926a875) opendht: 1.8.0 → 2.0.0
* [`79045d90`](NixOS/nixpkgs@79045d9) linuxPackages.ddcci-driver: 0.3.2 -> 0.3.3
* [`fe9b7e62`](NixOS/nixpkgs@fe9b7e6) uvcdynctrl: fix udev files
* [`e6a15db5`](NixOS/nixpkgs@e6a15db) nixos: default nix.maxJobs to auto
* [`7fc838bc`](NixOS/nixpkgs@7fc838b) python37Packages.xdis: 4.2.3 -> 4.2.4
* [`fafac02e`](NixOS/nixpkgs@fafac02) gitAndTools.git-cinnabar: init at 0.5.4
* [`e4f9166a`](NixOS/nixpkgs@e4f9166) skim: fix bash completion
* [`dbc8a54c`](NixOS/nixpkgs@dbc8a54) jackline: use OCaml 4.08
* [`67ea5a00`](NixOS/nixpkgs@67ea5a0) qalculate-gtk: 3.8.0 -> 3.8.0a
* [`ff3bc51d`](NixOS/nixpkgs@ff3bc51) chromiumBeta: Fix the build
* [`564af647`](NixOS/nixpkgs@564af64) cargo-make: 0.30.2 -> 0.30.4
* [`e2b327cd`](NixOS/nixpkgs@e2b327c) prometheus-wireguard-exporter: 3.2.4 -> 3.3.0
* [`e9916509`](NixOS/nixpkgs@e991650) robotfindskitten: 2.7182818.701 -> 2.8284271.702
* [`1859b5a5`](NixOS/nixpkgs@1859b5a) libvpx_1_8: init at 1.8.2
* [`9de3c974`](NixOS/nixpkgs@9de3c97) firefox: prepare for version 75
* [`4a41fd7a`](NixOS/nixpkgs@4a41fd7) firefox: 74.0.1 -> 75.0
* [`f56ea6cd`](NixOS/nixpkgs@f56ea6c) firefox-esr-68: 68.6.1esr -> 68.7.0esr
* [`bab82e78`](NixOS/nixpkgs@bab82e7) firefox-bin: 74.0.1 -> 75.0
* [`9d6a7fda`](NixOS/nixpkgs@9d6a7fd) firefox-beta-bin: 75.0b11 -> 76.0b1
* [`79fb5897`](NixOS/nixpkgs@79fb589) firefox-devedition-bin: 75.0b12 -> 76.0b1
* [`ed3128fd`](NixOS/nixpkgs@ed3128f) shfmt: 3.0.2 -> 3.1.0
* [`75c28ebd`](NixOS/nixpkgs@75c28eb) zfs: fix build against 5.6
* [`fed6a3d8`](NixOS/nixpkgs@fed6a3d) qmmp: 1.3.6 -> 1.3.7
* [`0f5c38fe`](NixOS/nixpkgs@0f5c38f) hydra: 2020-03-24 -> 2020-04-07
* [`0c7ec502`](NixOS/nixpkgs@0c7ec50) elisa: move into kdeApplications
* [`10f1ce04`](NixOS/nixpkgs@10f1ce0) tilda: 1.4.1 -> 1.5.0
* [`43177bec`](NixOS/nixpkgs@43177be) tcsh: 6.21.00 -> 6.22.02
* [`821527fa`](NixOS/nixpkgs@821527f) cached-nix-shell: init at 0.1.2
* [`f9423c14`](NixOS/nixpkgs@f9423c1) rspamd: 2.4 -> 2.5
* [`8b7e843d`](NixOS/nixpkgs@8b7e843) nixos: kafka test: fix building for other arches
* [`4971ace3`](NixOS/nixpkgs@4971ace) smbnetfs: 0.6.1 -> 0.6.2
* [`b85f9958`](NixOS/nixpkgs@b85f995) scowl: 2018.04.16 -> 2019.10.06
* [`73d63a68`](NixOS/nixpkgs@73d63a6) saga: 7.6.1 -> 7.6.2
* [`8c9f06e5`](NixOS/nixpkgs@8c9f06e) python3Packages.monty: fix tests
* [`d71ed93a`](NixOS/nixpkgs@d71ed93) lutris: 0.5.4 -> 0.5.5
* [`729000ea`](NixOS/nixpkgs@729000e) python3Packages.azure-storage: 0.20.3 -> 0.36.0
* [`2e04652e`](NixOS/nixpkgs@2e04652) python27Packages.virtualenv-clone: 0.5.3 -> 0.5.4
* [`7e4297fb`](NixOS/nixpkgs@7e4297f) python27Packages.stripe: 2.43.0 -> 2.44.0
* [`c2a5c900`](NixOS/nixpkgs@c2a5c90) python27Packages.whisper: 1.1.6 -> 1.1.7
* [`91203053`](NixOS/nixpkgs@9120305) python27Packages.simplekml: 1.3.3 -> 1.3.5
* [`a76df6a6`](NixOS/nixpkgs@a76df6a) python27Packages.spotipy: 2.9.0 -> 2.10.0
* [`b13722a7`](NixOS/nixpkgs@b13722a) python27Packages.yamllint: 1.20.0 -> 1.21.0
* [`1331a12c`](NixOS/nixpkgs@1331a12) scummvm: 2.1.1 -> 2.1.2
* [`a6ad30c9`](NixOS/nixpkgs@a6ad30c) python27Packages.txtorcon: 19.1.0 -> 20.0.0
* [`84b95b46`](NixOS/nixpkgs@84b95b4) python27Packages.soco: 0.18.1 -> 0.19
* [`a2ca4350`](NixOS/nixpkgs@a2ca435) python27Packages.graph-tool: 2.30 -> 2.31
* [`70e684d5`](NixOS/nixpkgs@70e684d) shotcut: 20.02.17 -> 20.04.01
* [`b914c284`](NixOS/nixpkgs@b914c28) python27Packages.patch-ng: 1.17.2 -> 1.17.4
* [`35837576`](NixOS/nixpkgs@3583757) conan: 1.23.0 -> 1.24.0
* [`efc01e88`](NixOS/nixpkgs@efc01e8) memcached: add nixos tests to passthru
* [`c5c3fc97`](NixOS/nixpkgs@c5c3fc9) memcached: 1.6.2 -> 1.6.3
* [`f34ccf11`](NixOS/nixpkgs@f34ccf1) munin: 2.0.51 -> 2.0.59
* [`041c890c`](NixOS/nixpkgs@041c890) python37Packages.nest-asyncio: 1.3.0 -> 1.3.2
* [`1c279a00`](NixOS/nixpkgs@1c279a0) obs-studio: 25.0.2 -> 25.0.3
* [`08070fff`](NixOS/nixpkgs@08070ff) nss_wrapper: 1.1.10 -> 1.1.11
* [`261bdcb2`](NixOS/nixpkgs@261bdcb) snd: 20.1 -> 20.2
* [`28d8bc72`](NixOS/nixpkgs@28d8bc7) seabios: 1.11.0 -> 1.13.0 (NixOS/nixpkgs#79880)
* [`bc23a9e2`](NixOS/nixpkgs@bc23a9e) python37Packages.starlette: 0.12.9 -> 0.13.2
* [`ae1b83c9`](NixOS/nixpkgs@ae1b83c) python37Packages.fastapi: 0.49.0 -> 0.54.0
* [`9df14757`](NixOS/nixpkgs@9df1475) pew: 1.1.2 -> 1.2.0, fix build
* [`c2cedac2`](NixOS/nixpkgs@c2cedac) spring: 104.0.1-1476-g0737b41 -> 104.0.1-1477-g8ecf38a
* [`52826281`](NixOS/nixpkgs@5282628) python27Packages.sqlmap: 1.4.3 -> 1.4.4
* [`d53c3ce2`](NixOS/nixpkgs@d53c3ce) stress-ng: 0.11.02 -> 0.11.07
* [`e4a7fe8f`](NixOS/nixpkgs@e4a7fe8) python3Packages.flask-reverse-proxy-fix: init at 0.2.1
* [`b9b3cdf0`](NixOS/nixpkgs@b9b3cdf) buku: 4.2.2 -> 4.3
* [`bf3e71ab`](NixOS/nixpkgs@bf3e71a) libgpiod: 1.5 -> 1.5.1
* [`d6d2007e`](NixOS/nixpkgs@d6d2007) groovy: 3.0.0 -> 3.0.2
* [`3e2e7a5c`](NixOS/nixpkgs@3e2e7a5) gnucash: 3.8b -> 3.9
* [`fe6302c7`](NixOS/nixpkgs@fe6302c) libzen: 0.4.37 -> 0.4.38
* [`455251ae`](NixOS/nixpkgs@455251a) thinkfan: 1.0.2 -> 1.1
* [`b296f001`](NixOS/nixpkgs@b296f00) vscode-extensions.ms-python.python: 2020.3.69010 -> 2020.3.71659
* [`dc8a843a`](NixOS/nixpkgs@dc8a843) vscode-extensions.ms-vscode.cpptools: 0.26.3 -> 0.27.0
* [`c824f1ec`](NixOS/nixpkgs@c824f1e) bacula: 9.6.2 -> 9.6.3
* [`d0dd8e6c`](NixOS/nixpkgs@d0dd8e6) notmuch: make emacs a separate output
* [`028fcf96`](NixOS/nixpkgs@028fcf9) notmuch: remove bash-completion and just specify path
* [`ff245d64`](NixOS/nixpkgs@ff245d6) clash: 0.18.0 -> 0.19.0
* [`92022012`](NixOS/nixpkgs@9202201) python37Packages.spyder: 4.1.1 -> 4.1.2
* [`1e713512`](NixOS/nixpkgs@1e71351) wordpress: 5.3.2 -> 5.4
* [`f89b76d9`](NixOS/nixpkgs@f89b76d) palp: correct metadata for repology
* [`0ea00213`](NixOS/nixpkgs@0ea0021) buildah: 1.14.6 -> 1.14.7
* [`d782c440`](NixOS/nixpkgs@d782c44) chromiumDev: Add the missing setuptools dependency
* [`388635f8`](NixOS/nixpkgs@388635f) josm: 15937 -> 16239
* [`233165ad`](NixOS/nixpkgs@233165a) unrar: 5.9.1 -> 5.9.2
* [`25c3d0da`](NixOS/nixpkgs@25c3d0d) qcad: init at 3.24.2.1 (NixOS/nixpkgs#81209)
* [`da832dd7`](NixOS/nixpkgs@da832dd) chromium: 80.0.3987.163 -> 81.0.4044.92
* [`0a43c6e0`](NixOS/nixpkgs@0a43c6e) zfs: Add enablePython argument
* [`f7b0d0e4`](NixOS/nixpkgs@f7b0d0e) xpra: 3.0.7 -> 3.0.8
* [`7c8d2179`](NixOS/nixpkgs@7c8d217) libbass: fix sha
* [`190f3a6c`](NixOS/nixpkgs@190f3a6) shfmt: set ldflags
* [`2e231d51`](NixOS/nixpkgs@2e231d5) pythonPackages.ipyvue: init at 1.3.1
* [`0261e874`](NixOS/nixpkgs@0261e87) pythonPackages.ipyvuetify: init at 1.2.2
* [`201aacce`](NixOS/nixpkgs@201aacc) python3Packages.qiskit-ibmq-provider: 0.5.0 -> 0.6.0
* [`42a12710`](NixOS/nixpkgs@42a1271) pythonPackages.IBMQuantumExperience: remove deprecated package
* [`e6b50a24`](NixOS/nixpkgs@e6b50a2) pythonPackages.qiskit: 0.14.0 -> 0.17.0
* [`09cd8b63`](NixOS/nixpkgs@09cd8b6) python3Packages.qiskit-aqua: disable slow tests
* [`0f36050b`](NixOS/nixpkgs@0f36050) xonsh: 0.9.15 -> 0.9.16
* [`09a1f3f6`](NixOS/nixpkgs@09a1f3f) vault: 1.3.4 -> 1.4.0
* [`9de87dcf`](NixOS/nixpkgs@9de87dc) flrig: 1.3.49 -> 1.3.50
* [`de6ba564`](NixOS/nixpkgs@de6ba56) fldigi: 4.1.09 -> 4.1.11
* [`72cb79e0`](NixOS/nixpkgs@72cb79e) libmediainfo: 19.09 -> 20.03
* [`53c6b76d`](NixOS/nixpkgs@53c6b76) fwts: 20.02.00 -> 20.03.00
* [`89424e14`](NixOS/nixpkgs@89424e1) maintainers: add cpcloud to maintainer-list.nix
* [`9c2ffc58`](NixOS/nixpkgs@9c2ffc5) scmpuff: init at 0.3.0
* [`94eb65a2`](NixOS/nixpkgs@94eb65a) nixos/gnome-remote-desktop: enable pipewire
* [`f4ff33cc`](NixOS/nixpkgs@f4ff33c) alt-ergo: 2.3.1 → 2.3.2
* [`0195347f`](NixOS/nixpkgs@0195347) beast: drop
* [`db46da2e`](NixOS/nixpkgs@db46da2) monotoneViz: do not use aliases
* [`ba2b0bdc`](NixOS/nixpkgs@ba2b0bd) relfs: drop
* [`14be4ca2`](NixOS/nixpkgs@14be4ca) lingot: 0.9.1 → 1.0.1
* [`bd166685`](NixOS/nixpkgs@bd16668) libreoffice-still: drop gnome2 dependencies
* [`a005ffe9`](NixOS/nixpkgs@a005ffe) bettercap: 2.26.1 -> 2.27
* [`9902849e`](NixOS/nixpkgs@9902849) cheat: 3.8.0 -> 3.9.0
* [`29d76cf0`](NixOS/nixpkgs@29d76cf) gnome3.gnome-remote-desktop: 0.1.7 -> 0.1.8 (NixOS/nixpkgs#84697)
* [`f396fe66`](NixOS/nixpkgs@f396fe6) sqlint: 0.1.9 -> 0.1.10
* [`b3fbd221`](NixOS/nixpkgs@b3fbd22) syncthing: 1.4.1 -> 1.4.2
* [`fdedc5d1`](NixOS/nixpkgs@fdedc5d) signal-desktop: 1.32.3 -> 1.33.0
* [`66c05279`](NixOS/nixpkgs@66c0527) jellyfin: 10.5.2 -> 10.5.3
* [`20fd0544`](NixOS/nixpkgs@20fd054) androidStudioPackages.beta: 4.0.0.12 -> 4.0.0.13
* [`49cc7392`](NixOS/nixpkgs@49cc739) gns3-{gui,server}: 2.2.6 -> 2.2.7
* [`af476597`](NixOS/nixpkgs@af47659) python3.pkgs.libmodulemd: init bindings
* [`4dee2897`](NixOS/nixpkgs@4dee289) grantlee: 5.1.0 -> 5.2.0 (NixOS/nixpkgs#84621)
* [`0fc7da19`](NixOS/nixpkgs@0fc7da1) kdeFrameworks: 5.66 -> 5.68 (NixOS/nixpkgs#84622)
* [`df907c47`](NixOS/nixpkgs@df907c4) openblas: Add `singleThreaded` option. Off by default.
* [`bb44abe5`](NixOS/nixpkgs@bb44abe) nixos/release-combined.nix: fix tested/supportedSystems
* [`918cb88d`](NixOS/nixpkgs@918cb88) nixos/release-combined.nix: test hibernate only on x86_64
* [`457900c7`](NixOS/nixpkgs@457900c) monolith: init at 2.2.2
* [`0669cd72`](NixOS/nixpkgs@0669cd7) g15daemon: init at 1.9.5.3
* [`56533379`](NixOS/nixpkgs@5653337) linux: 5.4.30 -> 5.4.31
* [`1c637d23`](NixOS/nixpkgs@1c637d2) linux: 5.5.15 -> 5.5.16
* [`7bd91fe7`](NixOS/nixpkgs@7bd91fe) linux: 5.6.2 -> 5.6.3
* [`c4c017f9`](NixOS/nixpkgs@c4c017f) zoom-us: 3.5.374815.0324 -> 3.5.383291.0407
* [`472d5c18`](NixOS/nixpkgs@472d5c1) php.buildEnv: Don't inherit dev from the original php
* [`2a7a7a81`](NixOS/nixpkgs@2a7a7a8) librsvg: fix build on darwin
* [`52ad14bb`](NixOS/nixpkgs@52ad14b) youtube-viewer: 3.3.0 -> 3.7.5
* [`1ae03c9d`](NixOS/nixpkgs@1ae03c9) linuxPackages.acpi-call: switch to nix-community fork
* [`a74ecff7`](NixOS/nixpkgs@a74ecff) shortwave: init at 1.0.1
* [`07bc7b97`](NixOS/nixpkgs@07bc7b9) nixos/initrd-ssh: fix typo (NixOS/nixpkgs#84719)
* [`4b4c0164`](NixOS/nixpkgs@4b4c016) malcontent: 0.6.0 → 0.7.0
* [`f3d1333f`](NixOS/nixpkgs@f3d1333) malcontent-ui: split from malcontent
* [`4e68e0a5`](NixOS/nixpkgs@4e68e0a) malcontent: Fix installed tests
* [`309fed2b`](NixOS/nixpkgs@309fed2) nixos/malcontent: enable accounts-daemon, tweak description
* [`44e56c25`](NixOS/nixpkgs@44e56c2) kmon: 1.0.0 -> 1.0.1
* [`e8b19c09`](NixOS/nixpkgs@e8b19c0) bazel_2: fix test paths
* [`955b44b3`](NixOS/nixpkgs@955b44b) bazel_1: fix test paths
* [`70308c5c`](NixOS/nixpkgs@70308c5) device-tree_rpi: fix platforms
* [`2011c203`](NixOS/nixpkgs@2011c20) ripgrep-all: 0.9.3 -> 0.9.5 (NixOS/nixpkgs#84714)
* [`beae5a9c`](NixOS/nixpkgs@beae5a9) manual/rl-2009.xml: Fix literal closing tag
* [`128baaf5`](NixOS/nixpkgs@128baaf) dbeaver: 7.0.1 -> 7.0.2
* [`662514f4`](NixOS/nixpkgs@662514f) nodejs-10_x: 10.19.0 -> 10.20.0
* [`b9b8388e`](NixOS/nixpkgs@b9b8388) vocal: add missing glib-networking
* [`9449ee6c`](NixOS/nixpkgs@9449ee6) pythonPackages.python-baseconv: init at 1.2.2
* [`4c7467a9`](NixOS/nixpkgs@4c7467a) maintainers: add s1341 as a maintainer
* [`f1090bda`](NixOS/nixpkgs@f1090bd) page: init at 2.3.4
* [`b1aca4f6`](NixOS/nixpkgs@b1aca4f) pythonPackages.morphys: init at 1.0
* [`3847ec0e`](NixOS/nixpkgs@3847ec0) nginxMainline: 1.17.8 -> 1.17.9 (NixOS/nixpkgs#84743)
* [`6be41c6d`](NixOS/nixpkgs@6be41c6) cawbird: 1.0.4 -> 1.0.5
* [`d9b010cd`](NixOS/nixpkgs@d9b010c) plex: 1.18.9.2578 -> 1.19.1.2630
* [`05f3d961`](NixOS/nixpkgs@05f3d96) pcsc-cyberjack: Fix build against libusb
* [`479c521a`](NixOS/nixpkgs@479c521) Automatically restart netdata on failures
* [`0880c9fe`](NixOS/nixpkgs@0880c9f) viu: 0.2.1 -> 1.0 (NixOS/nixpkgs#84746)
* [`788f5723`](NixOS/nixpkgs@788f572) nixos/release-notes: mention that dhcpcd stopped giving IPv4 addresses to bridges by default
* [`677b2d81`](NixOS/nixpkgs@677b2d8) bazel_0_26: fix linker flags for darwin (NixOS/nixpkgs#84614)
@github-actions github-actions bot mentioned this pull request Apr 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yvesf @FRidh @zimbatm