Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/matrix-synapse: remove web_client option #81212

Merged
merged 1 commit into from Apr 4, 2020
Merged

nixos/matrix-synapse: remove web_client option #81212

merged 1 commit into from Apr 4, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Feb 27, 2020

There is web_client_location as a replacement, however I'm reluctant to add it because it makes it easy to run web client on the same domain as homeserver, which is considered security risk. Maybe if matrix-org/synapse#7006 is merged we can add it with a warning?

Motivation for this change

Option was removed in matrix-synapse-0.34.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata
nixos/matrix-synapse: remove web_client option
2acddcb 
Removed in matrix-synapse-0.34.
@mmilata
Copy link
Member Author

mmilata commented Apr 4, 2020

cc @Ma27 @Ralith @roblabla

@Ma27
Copy link
Member

Ma27 commented Apr 4, 2020

@GrahamcOfBorg test matrix-synapse

@Ma27 Ma27 merged commit 5572974 into NixOS:master Apr 4, 2020
@Ma27
Copy link
Member

Ma27 commented Apr 4, 2020

@mmilata thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ralith Ralith Ralith approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mmilata @Ma27 @Ralith