Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NixOS/auto-upgrade: Add optional randomized delay #81214

Merged
merged 3 commits into from Mar 12, 2020
Merged

NixOS/auto-upgrade: Add optional randomized delay #81214

merged 3 commits into from Mar 12, 2020

Conversation

buckley310
Copy link
Contributor

Motivation for this change

This setting allows users to spread automatic updates out over a period of time, avoiding a synchronized bandwidth/CPU load increase.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@buckley310 @killercup
NixOS/auto-upgrade: fix wording
14a1aa4 
Co-Authored-By: Pascal Hertleif <killercup@gmail.com>
nlewo
nlewo requested changes Mar 3, 2020
View reviewed changes
nixos/modules/tasks/auto-upgrade.nix Outdated Show resolved Hide resolved
@buckley310 buckley310 requested a review from nlewo March 11, 2020 21:23
@nlewo
Copy link
Member

nlewo commented Mar 12, 2020

@buckley310 I'm just wondering: are you doing this because you are upgrading several machines (maybe a lot)?

Thanks.

@nlewo nlewo merged commit cbb21b2 into NixOS:master Mar 12, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Mar 12, 2020
@nlewo @dtzWill
Merge pull request NixOS#81214 from buckley310/updateDelay
ad87dd3 
NixOS/auto-upgrade: Add optional randomized delay

(cherry picked from commit cbb21b2)
@buckley310
Copy link
Contributor Author

@buckley310 I'm just wondering: are you doing this because you are upgrading several machines (maybe a lot)?

Thanks.

Not at the moment. However, since as of 20.03 you can add Nixos to Active Directory without any patches, I've been trying it in a couple of places at work, and if we ever did end up with a whole bunch of them, I would want this setting available.

@buckley310 buckley310 deleted the updateDelay branch October 8, 2020 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killercup killercup killercup left review comments

@nlewo nlewo Awaiting requested review from nlewo

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@buckley310 @nlewo @killercup