Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ausweisapp2: init at 1.20.0 #81210

Merged
merged 2 commits into from Apr 20, 2020
Merged

ausweisapp2: init at 1.20.0 #81210

merged 2 commits into from Apr 20, 2020

Conversation

B4dM4n
Copy link
Contributor

@B4dM4n B4dM4n commented Feb 27, 2020 •
edited

Motivation for this change

Add a build for the AusweisApp2 project.

Fixes #80415

Things done

Build and run successfully under NixOS. I couldn't get the macOS build running because of the required pcsc paths and the special cmake install handling for macOS.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@doronbehar
Copy link
Contributor

Requested in #80415

@B4dM4n Could you please edit it so it'll say:

Fixes #80415

This way, github'll automatically close that one :).

doronbehar
doronbehar approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect :).

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Mar 12, 2020

Requested in #80415

@B4dM4n Could you please edit it so it'll say:

Fixes #80415

This way, github'll automatically close that one :).

Description is updated.

timokau
timokau approved these changes Apr 18, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

timokau
timokau requested changes Apr 18, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh one more thing: Please squash your last two commits together (git rebase -i origin/master, mark the latest commit as "fixup"). The end result should only be two commits: Adding the license and adding the package.

@B4dM4n
Copy link
Contributor Author

B4dM4n commented Apr 19, 2020

Done, the branch is rebased and squashed.

@timokau
Copy link
Member

timokau commented Apr 20, 2020

Great, thanks again :)

@timokau timokau merged commit 166bf23 into NixOS:master Apr 20, 2020
@B4dM4n B4dM4n deleted the ausweisapp2 branch April 20, 2020 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@doronbehar doronbehar doronbehar approved these changes

@alyssais alyssais Awaiting requested review from alyssais alyssais is a code owner

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFP: ausweisapp2
3 participants
@B4dM4n @doronbehar @timokau