New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Double-click to rename vehicle #8008
Conversation
It's not complicated already, same two clicks, just with some mouse movement in between. Perfectly ok for not so widely used function IMO. Totally not worth adding another obscure interface quirk that 99% of players won't even know about. Also, double click will probably bring even more suffer and despair to touchscreen ports UI. |
As far as I know, pretty many people use this function, and I think clicking on its name to rename vehicle is intuitive enough. |
add824c
to
d7edbac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any issue with this in principle...
It would be great if we can add a configuration for this if you don't disagree with increasing the number of settings. |
7b403f2
to
cda6f57
Compare
@telk5093 Now I added option to enable/disable it. |
I don't agree with having a setting here. This isn't something that visibly changes the behaviour/look of the game. If you don't want to double-click... don't |
cda6f57
to
41803e1
Compare
@LordAro hmm... now reverted to original version. |
I could double click on a competitor road vehicle and try rename it, only to get an error saying it's not mine. The tooltip doesn't mention anything about double-click to rename, only to drag. |
Somehow the OpenTTD CI broke on this pull request and several others. One of the checks is saying "Expected" for months, the OpenTTD CI logs aren't found, but the Commit checker logs are still accessible. Maybe try running the checks again? |
41803e1
to
dfc1f96
Compare
Fixed |
dfc1f96
to
70e4718
Compare
Currently, renaming things can be a pain. Would we be better served by placing a small “edit” icon next to re-nameable items? In instances where this name appears as the title of a window, the title bar seems like a perfectly logical place for such an icon. |
To add my opinion to the pile:
|
Many people have different expectations of their UI, depending on what they are used to in their day-to-day. OpenTTD's UI dates to, what, 1994, and wasn't aware of the many common concepts we have today. In result, it is a mixed bag of everything that was and was becoming. In short: the UI sucks :P That said, I can fully understand that functionalities like this help some people, but that it frustrates the hell out of others. This needs a more generic fix, for example with presets or what-ever, to allow patches like this. To not poke the bear too much, sadly, I think we should close this PR for now. I do not expect that we come to a consensus about it any time soon, and allowing any form of presets (or themes, or how-ever you want to call it) will take a while. I am really sorry, as I personally like it :D |
Renaming vehicle is a bit complicated in current state, so renaming a number of vehicles takes long time. This patch allows double-click title bar of vehicle view window to rename vehicles.