Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/rdma-core: 27.0 -> 28.0, update RXE module #81277

Merged
merged 3 commits into from Mar 22, 2020
Merged

nixos/rdma-core: 27.0 -> 28.0, update RXE module #81277

merged 3 commits into from Mar 22, 2020

Conversation

markuskowa
Copy link
Member

Motivation for this change

Update package and NixOS module

Things done
  • rdma-core: 27.0 -> 28.0
  • update rxe module, replace rxe_cfg with rdma
  • build iproute with libmnl to enable build of rmda utility
  • update rxe test
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
iproute: add libmnl to build rdma utility
ae91282
@markuskowa
rdma-core: 27.0 -> 28.0
505bccf 
rxe_cfg has been removed, is replaced by
'rdma' from iproute package.
@markuskowa
Copy link
Member Author

markuskowa commented Feb 29, 2020 •
edited

@GrahamcOfBorg test rxe

@markuskowa markuskowa changed the base branch from master to staging March 6, 2020 23:17
@markuskowa markuskowa requested review from jonringer, aij and Mic92 and removed request for edolstra March 7, 2020 14:42
@markuskowa
nixos/rxe: use iproute instead of rdma-core
2c7f8d5 
The rdma-core packages dropped rxe_cfg in favour
of iproute's rdma utility (see https://github.com/linux-rdma/rdma-core/pull/678/files)
@ofborg ofborg bot requested a review from edolstra March 12, 2020 21:41
aij
aij approved these changes Mar 12, 2020
View reviewed changes
Copy link
Contributor

@aij aij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Mic92
Mic92 approved these changes Mar 13, 2020
View reviewed changes
Copy link
Member

@Mic92 Mic92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not actually tested it though.

@markuskowa markuskowa merged commit a9d7a1e into NixOS:staging Mar 22, 2020
@markuskowa markuskowa deleted the upd-rdma-core branch March 22, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@aij aij aij approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@primeos primeos Awaiting requested review from primeos

@globin globin Awaiting requested review from globin

@jonringer jonringer Awaiting requested review from jonringer

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markuskowa @Mic92 @aij