Skip to content
This repository was archived by the owner on Apr 12, 2021. It is now read-only.
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b1ec189c9faa
Choose a base ref
...
head repository: NixOS/nixpkgs-channels
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 544baad62200
Choose a head ref
  • 10 commits
  • 8 files changed
  • 4 contributors

Commits on Feb 15, 2020

  1. Copy the full SHA
    4594022 View commit details

Commits on Feb 26, 2020

  1. arrow-cpp: 0.15.1 -> 0.16.0

    This switches to explicitly enabling dependency lookups for
    optional features (they were not picked up before).
    It also enables building of the Parquet command line tools.
    tobim committed Feb 26, 2020
    Copy the full SHA
    5ddadce View commit details

Commits on Feb 27, 2020

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    4b65f85 View commit details
  2. arrow-cpp: fix RPATH on darwin

    Instead of patching test binaries with install_name_tool just set
    CMAKE_SKIP_BUILD_RPATH to OFF let cmake compile them with RPATH set
    correctly.
    
    Add CMAKE_INSTALL_RPATH to set correct RPATH for the installed
    executables for parquet tools. We could set it to an absolute path using
    "-DCMAKE_INSTALL_RPATH=${placeholder "out"}", but instead we use
    @loader_path to provide a relocable solution.
    veprbl committed Feb 27, 2020
    Copy the full SHA
    56c2b7c View commit details
  3. ycmd: 2019-09-19 -> 2020-02-22

    drop support for python2
    
    ycmd dropped support for python2 with ycm-core/ycmd#1382
    
    youcompleteme dropped support for python2 with ycm-core/YouCompleteMe#3566
    evanjs authored and Jon committed Feb 27, 2020
    Copy the full SHA
    5e895e5 View commit details
  4. vimPlugins: update

    evanjs authored and Jon committed Feb 27, 2020
    Copy the full SHA
    6bb6882 View commit details
  5. Copy the full SHA
    1e20ec8 View commit details
  6. Copy the full SHA
    8979041 View commit details

Commits on Feb 28, 2020

  1. Copy the full SHA
    fbc88db View commit details
  2. Merge pull request #79817 from tobim/pkgs/arrow-cpp-0.16

    arrow-cpp: 0.15.1 -> 0.16.0
    veprbl authored Feb 28, 2020
    Copy the full SHA
    544baad View commit details
54 changes: 36 additions & 18 deletions pkgs/development/libraries/arrow-cpp/default.nix
Original file line number Diff line number Diff line change
@@ -1,24 +1,24 @@
{ stdenv, lib, fetchurl, fetchFromGitHub, fixDarwinDylibNames, autoconf, boost
, brotli, cmake, double-conversion, flatbuffers, gflags, glog, gtest, lz4, perl
, python, rapidjson, snappy, thrift, uriparser, which, zlib, zstd
{ stdenv, lib, fetchurl, fetchFromGitHub, fetchpatch, fixDarwinDylibNames, autoconf, boost
, brotli, cmake, flatbuffers, gflags, glog, gtest, lz4, perl
, python, rapidjson, snappy, thrift, which, zlib, zstd
, enableShared ? true }:

let
parquet-testing = fetchFromGitHub {
owner = "apache";
repo = "parquet-testing";
rev = "a277dc4e55ded3e3ea27dab1e4faf98c112442df";
sha256 = "1yh5a8l4ship36hwmgmp2kl72s5ac9r8ly1qcs650xv2g9q7yhnq";
rev = "46c9e977f58f6c5ef1b81f782f3746b3656e5a8c";
sha256 = "1z2s6zh58nf484s0yraw7b1aqgx66dn2wzp1bzv9ndq03msklwly";
};

in stdenv.mkDerivation rec {
pname = "arrow-cpp";
version = "0.15.1";
version = "0.16.0";

src = fetchurl {
url =
"mirror://apache/arrow/arrow-${version}/apache-arrow-${version}.tar.gz";
sha256 = "1jbghpppabsix2rkxbnh41inj9lcxfz4q94p96xzxshh4g3mhb4s";
sha256 = "1xdp1yni9i1cpml326s78qql1g832m800h7zjlqmk89983g94696";
};

sourceRoot = "apache-arrow-${version}/cpp";
@@ -35,6 +35,14 @@ in stdenv.mkDerivation rec {
patches = [
# patch to fix python-test
./darwin.patch
# Adjust CMake target names to make -DCMAKE_FIND_PACKAGE_PREFER_CONFIG=ON work.
# Remove this when updating to the next version.
(fetchpatch {
name = "arrow-use-upstream-cmake-target-names.patch";
url = "https://github.com/apache/arrow/commit/396861b38d2f4e805db7c2ecd2c96fff0ca2678b.patch";
sha256 = "0ki7nx858374anvwyi4szz5hgnnzv4fghdd05c38bzry9rfljgb1";
stripLen = 1;
})
] ++ lib.optionals (!enableShared) [
# The shared jemalloc lib is unused and breaks in static mode due to missing -fpic.
./jemalloc-disable-shared.patch
@@ -48,7 +56,6 @@ in stdenv.mkDerivation rec {
buildInputs = [
boost
brotli
double-conversion
flatbuffers
gflags
glog
@@ -57,7 +64,6 @@ in stdenv.mkDerivation rec {
rapidjson
snappy
thrift
uriparser
zlib
zstd
python.pkgs.python
@@ -71,29 +77,41 @@ in stdenv.mkDerivation rec {
'';

cmakeFlags = [
"-DCMAKE_FIND_PACKAGE_PREFER_CONFIG=ON"
"-DARROW_BUILD_TESTS=ON"
"-DARROW_DEPENDENCY_SOURCE=SYSTEM"
"-DARROW_PARQUET=ON"
"-DARROW_PLASMA=ON"
# Disable Python for static mode because openblas is currently broken there.
"-DARROW_PYTHON=${if enableShared then "ON" else "OFF"}"
"-Duriparser_SOURCE=SYSTEM"
"-DARROW_USE_GLOG=ON"
"-DARROW_WITH_BROTLI=ON"
"-DARROW_WITH_LZ4=ON"
"-DARROW_WITH_SNAPPY=ON"
"-DARROW_WITH_ZLIB=ON"
"-DARROW_WITH_ZSTD=ON"
# Parquet options:
"-DARROW_PARQUET=ON"
"-DPARQUET_BUILD_EXECUTABLES=ON"
"-DTHRIFT_COMPILER=${thrift}/bin/thrift"
"-DTHRIFT_VERSION=${thrift.version}"
] ++ lib.optionals (!enableShared) [
"-DARROW_BUILD_SHARED=OFF"
"-DARROW_BOOST_USE_SHARED=OFF"
"-DARROW_GFLAGS_USE_SHARED=OFF"
"-DARROW_PROTOBUF_USE_SHARED=OFF"
"-DARROW_TEST_LINKAGE=static"
"-DOPENSSL_USE_STATIC_LIBS=ON"
] ++ lib.optionals stdenv.isDarwin [
"-DCMAKE_SKIP_BUILD_RPATH=OFF" # needed for tests
"-DCMAKE_INSTALL_RPATH=@loader_path/../lib" # needed for tools executables
] ++ lib.optional (!stdenv.isx86_64) "-DARROW_USE_SIMD=OFF";

doInstallCheck = true;
PARQUET_TEST_DATA =
if doInstallCheck then "${parquet-testing}/data" else null;
installCheckInputs = [ perl which ];
installCheckPhase = (lib.optionalString stdenv.isDarwin ''
for f in release/*test{,s}; do
install_name_tool -add_rpath "$out"/lib "$f"
done
'')
+ (let
installCheckPhase =
let
excludedTests = lib.optionals stdenv.isDarwin [
# Some plasma tests need to be patched to use a shorter AF_UNIX socket
# path on Darwin. See https://github.com/NixOS/nix/pull/1085
@@ -103,7 +121,7 @@ in stdenv.mkDerivation rec {
in ''
ctest -L unittest -V \
--exclude-regex '^(${builtins.concatStringsSep "|" excludedTests})$'
'');
'';

meta = {
description = "A cross-language development platform for in-memory data";
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
diff --git a/cmake_modules/ThirdpartyToolchain.cmake b/cmake_modules/ThirdpartyToolchain.cmake
--- a/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cmake_modules/ThirdpartyToolchain.cmake
@@ -1428,6 +1428,7 @@ if(ARROW_JEMALLOC)
"--with-jemalloc-prefix=je_arrow_"
"--with-private-namespace=je_arrow_private_"
"--without-export"
+ "--disable-shared"
# Don't override operator new()
"--disable-cxx" "--disable-libdl"
# See https://github.com/jemalloc/jemalloc/issues/1237
@@ -1317,6 +1317,7 @@ if(ARROW_JEMALLOC)
"--with-jemalloc-prefix=je_arrow_"
"--with-private-namespace=je_arrow_private_"
"--without-export"
+ "--disable-shared"
# Don't override operator new()
"--disable-cxx" "--disable-libdl"
# See https://github.com/jemalloc/jemalloc/issues/1237
4 changes: 2 additions & 2 deletions pkgs/development/python-modules/pyarrow/default.nix
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{ lib, buildPythonPackage, python, isPy3k, arrow-cpp, cmake, cython, futures, hypothesis, numpy, pandas, pytest, pkgconfig, setuptools_scm, six }:
{ lib, buildPythonPackage, python, isPy3k, arrow-cpp, cmake, cython, futures, hypothesis, numpy, pandas, pytest, pytest-lazy-fixture, pkgconfig, setuptools_scm, six }:

let
_arrow-cpp = arrow-cpp.override { inherit python; };
@@ -13,7 +13,7 @@ buildPythonPackage rec {

nativeBuildInputs = [ cmake cython pkgconfig setuptools_scm ];
propagatedBuildInputs = [ numpy six ] ++ lib.optionals (!isPy3k) [ futures ];
checkInputs = [ hypothesis pandas pytest ];
checkInputs = [ hypothesis pandas pytest pytest-lazy-fixture ];

PYARROW_BUILD_TYPE = "release";
PYARROW_WITH_PARQUET = true;
26 changes: 26 additions & 0 deletions pkgs/development/python-modules/pytest-lazy-fixture/default.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
{ lib
, buildPythonPackage
, fetchPypi
, pytestCheckHook
}:

buildPythonPackage rec {
pname = "pytest-lazy-fixture";
version = "0.6.3";

src = fetchPypi {
inherit pname version;
sha256 = "1b0hmnsxw4s2wf9pks8dg6dfy5cx3zcbzs8517lfccxsfizhqz8f";
};

checkInputs = [
pytestCheckHook
];

meta = with lib; {
description = "Helps to use fixtures in pytest.mark.parametrize";
homepage = "https://github.com/pytest-dev/pytest-repeat";
license = licenses.mit;
maintainers = with maintainers; [ tobim ];
};
}
7 changes: 4 additions & 3 deletions pkgs/development/tools/misc/ycmd/default.nix
Original file line number Diff line number Diff line change
@@ -8,12 +8,13 @@

stdenv.mkDerivation {
pname = "ycmd";
version = "2019-09-19";
version = "2020-02-22";
disabled = !python.isPy3k;

src = fetchgit {
url = "https://github.com/Valloric/ycmd.git";
rev = "c6d360775b0c5c82e2513dce7b625f8bf3812702";
sha256 = "19rxlval20gg65xc5p7q9cnzfm9zw2j0m6vxxk0vqlalcyh0rnzd";
rev = "9a6b86e3a156066335b678c328f226229746bae5";
sha256 = "1c5axdngxaxj5vc6lr8sxb99mr5adsm1dnjckaxc23kq78pc8cn7";
};

nativeBuildInputs = [ cmake ];
Loading