New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #7644: (Cocoa) Manually set colorspace to sRGB #8023
Conversation
060ace2
to
2c22838
Compare
2c22838
to
513de80
Compare
Crashes for me on macOS 10.13.6 (Macbook Pro, late 2010 model). I haven't looked into the details of the crash yet.
|
I tested from a clean starting point. Just adding the |
513de80
to
ac6f592
Compare
@nielsmh Thanks for checking, I was running without assertions which hid this error! Latest commit fixes the crash you experienced, WindowResized was being called before the colorspace was set. Although if you feel it's cleaner I/you can also remove the color_space member variable... |
ac6f592
to
da504c1
Compare
Thanks for the review, I've implemented both requested changes. |
Seems to work better for me on 10.14.6 (MacBook Pro 15-inch 2019) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good enough
Performance is measurably better with this PR versus 1.10.0 beta 2 (using in-game FPS). This PR re-introduces the unfortunate magenta cast per #7644 (comment) Without wanting to be dramatic about it, that makes the game very visually unappealing, the magenta sprites are unpleasant and the contrast is significantly reduced. I guess there might just be no remedy for that. |
This commit manually sets the colorspace for the window to sRGB, as suggested in #7644 by @SoothedTau, to fix performance issues on OSX when using devices that use the P3 colorspace by default. This makes the game run smoothly on my laptop, with the full 33fps rate.