Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix node updater #81275

Closed
wants to merge 2 commits into from
Closed

fix node updater #81275

wants to merge 2 commits into from

Conversation

iv-nn
Copy link
Contributor

@iv-nn iv-nn commented Feb 28, 2020 •
edited

Motivation for this change

The following error since #70974 when running ./generate.sh:

./generate.sh: line 5: cd: /home/user/src/nixpkgs/pkgs/development/node-packages/pkgs/development/node-packages: No such file or directory

$NODE_NIXPKGS_PATH already points to /pkgs/development/node-packages, appending it again makes the path erroneous.

Things done

removed duplicate trailing path.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@iv-nn iv-nn changed the title Fix node updater fix node updater Feb 28, 2020
@iv-nn
Copy link
Contributor Author

iv-nn commented Feb 28, 2020

I should probably have opened an issue to discuss this before. It looked like an easy fix but something else must be wrong since now the composition-v*.nix contains:

nodeEnv = import ../../../../home/user/src/nixpkgs/pkgs/development/node-packages/node-env.nix

I don't know enough about node2nix to find the issue.

@iv-nn
Copy link
Contributor Author

iv-nn commented Feb 28, 2020

It seems to be related to the new temp directory used by generate.sh, node2nix use absolute paths if some of it's parameters are absolute paths.

@rileyinman
Copy link
Contributor

+1, I had to revert my generate.sh to an older commit in order to rebase my node-packages PR to master since the new version kept breaking things. In my opinion the previous version should be restored until this new idea can be fully tested.

@iv-nn
nodePackages: remove duplicate trailing path
16cd762 
$NODE_NIXPKGS_PATH already points to /pkgs/development/node-packages,
appending it again makes the path erroneous.
@iv-nn
nodePackages: generate without a tmpdir
83b457b
@iv-nn iv-nn mentioned this pull request Mar 1, 2020
Closed
10 tasks
mmilata
mmilata approved these changes Mar 6, 2020
View reviewed changes
Copy link
Member

@mmilata mmilata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the problem for me:+1:.

@iv-nn
Copy link
Contributor Author

iv-nn commented Mar 28, 2020

Fixed in 216c58a

@iv-nn iv-nn closed this Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmilata mmilata mmilata approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iv-nn @rileyinman @mmilata