Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

codimd: 1.5.0 -> 1.6.0 #81281

Merged
merged 2 commits into from Feb 28, 2020
Merged

codimd: 1.5.0 -> 1.6.0 #81281

merged 2 commits into from Feb 28, 2020

Conversation

WilliButz
Copy link
Member

Motivation for this change

https://github.com/codimd/server/releases/tag/1.6.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz WilliButz requested a review from Ma27 February 28, 2020 11:00
@WilliButz
Copy link
Member Author

@GrahamcOfBorg test codimd

@ofborg ofborg bot requested a review from globin February 28, 2020 11:17
Ma27
Ma27 reviewed Feb 28, 2020
View reviewed changes
Copy link
Member

@Ma27 Ma27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce ofborg's hash-mismatch locally as well:

js-sequence-diagrams-b9afa03> removing `.git'...
hash mismatch in fixed-output derivation '/nix/store/0h754dqachgmhs9pasv4i4fs0i0iwi3s-js-sequence-diagrams-b9afa03':
  wanted: sha256:1fg3xsyndh7lnd9hqxazv2p01l2p6q5pv72scrcrrf2arbizgk35
  got:    sha256:12v57bdld5a2550xvqh1rcinpld48awgd1s0gbny7z0b0z827ggw
cannot build derivation '/nix/store/m254cqvk82fq5wv6dhh2l5s1i347nki5-js-sequence-diagrams.git.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mzdxk9jlgbgn5xj2v3rd0x13gxlp2wan-offline.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jp6gkgri19107rjzq73i2bi6ca9g3gvx-CodiMD-modules-1.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/wcqxgvk65g06h1pwg9vm0p28agz6m0sc-codimd.drv': 1 dependencies couldn't be built
[265 built (1 failed), 1219 copied (103.5 MiB), 59.7 MiB DL]
error: build of '/nix/store/wcqxgvk65g06h1pwg9vm0p28agz6m0sc-codimd.drv' failed

@WilliButz
Copy link
Member Author

Oh, I can confirm it as well. I'll check for a successful build on another host first and will update the PR after that.

@WilliButz
Copy link
Member Author

@GrahamcOfBorg test codimd

@ofborg ofborg bot requested a review from Ma27 February 28, 2020 13:46
@Ma27 Ma27 merged commit 475eaa1 into NixOS:master Feb 28, 2020
@Ma27 Ma27 mentioned this pull request Mar 4, 2020
Merged
10 tasks
@WilliButz WilliButz deleted the update-codimd branch March 6, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WilliButz @Ma27