Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reaper: update to 6.04, fix libjack2 missing dependency #81282

Closed
wants to merge 1 commit into from
Closed

reaper: update to 6.04, fix libjack2 missing dependency #81282

wants to merge 1 commit into from

Conversation

bignaux
Copy link
Contributor

@bignaux bignaux commented Feb 28, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Fix #79763 #80486 @jfrankenau

@ofborg ofborg bot requested a review from jfrankenau February 28, 2020 11:16
@worldofpeace
Copy link
Contributor

Can you make two commits?

reaper: 5.987 -> 6.04
reaper: fix libjack2 missing dependency

@ghost ghost closed this May 18, 2020
@ghost
Copy link

ghost commented May 18, 2020

Replaced by #88049

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reaper – jack backend not configured
2 participants
@bignaux @worldofpeace