New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edid-generator: init at unstable-2018-03-15 #81200
Conversation
Something still seems to be wrong with these edid files:
|
5f74544
to
f7468cb
Compare
f7468cb
to
fa58182
Compare
Okay, I figured it out - some of the tooling didn't like the Removing this, I was able to build a working edid file. I added the package to |
Should this append "Modeline " to the front? it seems kind of redundant to specify it, only makes sense if you're parsing an xorg file. Plus is there much reason to make/install the already included .bin files? Maybe a flag |
I'm not sure if it's necessary - right now, this consumes the output of the $ cvt 1024 768 60
# 1024x768 59.92 Hz (CVT 0.79M3) hsync: 47.82 kHz; pclk: 63.50 MHz
Modeline "1024x768_60.00" 63.50 1024 1072 1176 1328 768 771 775 798 -hsync +vsync |
Shouldn't this package actually install the edid-generator script as well @flokli? That was my expectation. |
Yeah, this should probably be split, have a package for the edid generator, and another component to create the edid binaries. I'm not sure it that part should be a NixOS module, it feels more like a library function, that might also make sense to use independent of an individual NixOS instantiation. Would you mind opening a PR? |
I've been trying to get a custom EDID working for a couple of days, and have been documenting my progress with an eye towards upstreaming it in some form, but I'm stuck on two issues:
Do you mean a function in nixpkgs.lib to generate an EDID? I haven't been successful yet (and there may be some hard reason why I won't be, in display capabilities), so it's hard to know if this is right, but it seems like a good progression for customizing your EDID is:
At the very least, I'd like to add a specific NixOS kernel option for adding a custom EDID file, since doing it using extraParams is a bit complicated (I haven't gotten it working yet, this was my attempt so far: edrex/nixos-config@c7c5f82) |
i also want to package https://sourceforge.net/projects/wxedid/ |
Motivation for this change
I'd like to generate custom edids to drive display with custom modes on wayland.
This derivation exposes a
modelines
argument, which can be used to add arbitrary modelines.Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)