Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/service-runner.nix: Allow quotes in commands + test #81292

Merged
merged 1 commit into from Mar 3, 2020

Conversation

roberth
Copy link
Member

@roberth roberth commented Feb 28, 2020

Motivation for this change

Fixes a regression found when updating arion for 20.03. Makes config.systemd.services.nginx.runner work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@roberth
Copy link
Member Author

roberth commented Mar 2, 2020

@GrahamcOfBorg test service-runner

@flokli
Copy link
Contributor

flokli commented Mar 2, 2020

I'm not very confident extending that perl-based systemd alternative should really be the way to go forward here, and assume many NixOS modules already rely quite heavily on systemd-provided features such as tmpfiles, config/state/runtime directory provisioning, dynamic user/groups and different service type behaviours - probably it'd make more sense for people to handle startup themselves?

I think @nlewo has experimented with something non-systemd as well, maybe he can provide some insights?

@roberth
Copy link
Member Author

roberth commented Mar 3, 2020

@flokli It's currently broken and blocking arion's update to 20.03. So unless something is terribly wrong with the implementation of the fix, I think it's an improvement.
Is it ok to debate the future of the script after this pr? Like many unsound things, it seems quite useful.

@nlewo
Copy link
Member

nlewo commented Mar 3, 2020

I also think we should move forward on this PR as it is since bringing an alternative implementation is another kind of task:/

Note I would be really interested in discussing on alternative implementation. Actually, I had already started to work on a s6 implementation (which is unfortunately no longer maintained).

@roberth
Copy link
Member Author

roberth commented Mar 3, 2020

S6 looks like a great alternative for lighter containers. I'm not sure if that will replace this script, because it is something quite different, but it is certainly a better fit something like arion.

@roberth roberth merged commit 6734e58 into NixOS:master Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants