Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glances: move from python-module to application #81192

Merged
merged 1 commit into from Feb 29, 2020
Merged

glances: move from python-module to application #81192

merged 1 commit into from Feb 29, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 27, 2020 •
edited

Motivation for this change

top/htop alternative

Meant to be used an an application, and not a "library". Moved from python-modules to a top-level entry

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Valodim
Valodim reviewed Feb 27, 2020
View reviewed changes
pkgs/tools/system/glances/default.nix Outdated

# fix unitest.py
patches = [
( fetchpatch {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like a pretty small patch. is there a policy to prefer referencing patches like this, instead of including them directly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it has been merged into their master already, which is why I prefer the fetchpatch.

Also communicates that I don't need to upstream the fix

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, makes sense. maybe link to the upstream issue and mention it can be dropped on the next version bump? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct, oddly enough, this patch was made the same day as the last version. So I'm not sure if he forgot to include it in the release. Either way, it should be dropped next release, I'll make a note of it

Valodim
Valodim approved these changes Feb 27, 2020
View reviewed changes
Copy link
Contributor

@Valodim Valodim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as expected 👍

@jonringer
Copy link
Contributor Author

turns out there was already a glances python module. Now just exporting as a top-level alias

@jonringer jonringer changed the title glances: init at 3.1.3 glances: add top-level alias to python package Feb 27, 2020
@Mic92
Copy link
Member

Mic92 commented Feb 27, 2020

Since it does not seem to be a python library anyway, this could be moved out of python-packages.nix.

@ofborg ofborg bot requested a review from primeos February 27, 2020 17:35
@jonringer
Copy link
Contributor Author

@Mic92 true

I'll have some free time tonight. I'll do that later

@jonringer jonringer force-pushed the add-glances branch 3 times, most recently from 54b77d5 to 954375d Compare February 28, 2020 06:15
@jonringer jonringer changed the title glances: add top-level alias to python package glances: move from python-module to application Feb 28, 2020
@ofborg ofborg bot requested a review from primeos February 28, 2020 18:15
@jonringer
Copy link
Contributor Author

@FRidh does this deprecation look right to you?

primeos
primeos approved these changes Feb 29, 2020
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now :)

@jonringer jonringer merged commit cad9959 into NixOS:master Feb 29, 2020
@jonringer jonringer deleted the add-glances branch July 8, 2020 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Valodim Valodim Valodim approved these changes

@k0ral k0ral k0ral left review comments

@primeos primeos primeos approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonringer @Mic92 @Valodim @k0ral @primeos