Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/modprobe: Fix modprobe configuration manpage link #81224

Merged
merged 1 commit into from Jul 6, 2020
Merged

nixos/modprobe: Fix modprobe configuration manpage link #81224

merged 1 commit into from Jul 6, 2020

Conversation

chkno
Copy link
Member

@chkno chkno commented Feb 28, 2020

Motivation for this change

When the option description says "run man ____ for details", that should work.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

hax404
hax404 approved these changes Jun 11, 2020
View reviewed changes
Copy link
Contributor

@hax404 hax404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

mweinelt
mweinelt approved these changes Jun 20, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM.

mweinelt
mweinelt requested changes Jul 6, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, one final nit:

The commit message should probably start with nixos/modprobe: instead of nixos/boot.extraModprobeConfig:, because the module you are editing is modprobe.nix.

@chkno
Copy link
Member Author

chkno commented Jul 6, 2020 •
edited

The commit message should probably start with nixos/modprobe: instead of nixos/boot.extraModprobeConfig:, because the module you are editing is modprobe.nix.

Done.

@chkno chkno requested a review from mweinelt July 6, 2020 20:52
@mweinelt mweinelt changed the title nixos/boot.extraModprobeConfig: Fix modprobe configuration manpage link nixos/modprobe: Fix modprobe configuration manpage link Jul 6, 2020
mweinelt
mweinelt approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm. Merging.

@mweinelt mweinelt merged commit 8f357b7 into NixOS:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deraffe deraffe deraffe approved these changes

@mweinelt mweinelt mweinelt approved these changes

@hax404 hax404 hax404 approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@chkno @deraffe @mweinelt @hax404