Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

torchPackages, torch-repl: remove #81173

Merged
merged 1 commit into from Feb 28, 2020
Merged

torchPackages, torch-repl: remove #81173

merged 1 commit into from Feb 28, 2020

Conversation

teto
Copy link
Member

@teto teto commented Feb 27, 2020 •
edited

See #71888
and #56398

To sump up, development has moved on to other technologies than lua:
https://github.com/torch/torch7#development-status
and the current packages are broken anyway.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto teto mentioned this pull request Feb 27, 2020
Open
30 tasks
@teto
torchPackages, torch-repl: remove
3a11be5 
See NixOS#71888
and NixOS#56398

To sump up, development has moved on to other technologies than lua:
https://github.com/torch/torch7#development-status
and the current packages are broken anyway.
@teto teto mentioned this pull request Feb 27, 2020
Closed
@teto
Copy link
Member Author

teto commented Feb 27, 2020

cc @Fresheyeball @grwlf

@teto teto merged commit 05b6836 into NixOS:master Feb 28, 2020
@teto teto deleted the remove_lua_torch branch February 28, 2020 19:56
@nh2 nh2 mentioned this pull request Mar 28, 2020
Merged
10 tasks
bhipple added a commit to bhipple/nixpkgs that referenced this pull request Mar 28, 2020
@bhipple
aliases.nix: add aliases for removed torch packages
a80ed9f 
We've removed the abandoned and broken torch project as part of NixOS#71888

This commit adds aliases for:

- NixOS#81173
- NixOS#83568
@bhipple bhipple mentioned this pull request Mar 28, 2020
Merged
bhipple added a commit to bhipple/nixpkgs that referenced this pull request Mar 28, 2020
@bhipple
aliases.nix: add aliases for removed torch packages
4a3f221 
We've removed the abandoned and broken torch project as part of NixOS#71888

This commit adds aliases for:

- NixOS#81173
- NixOS#83568

(cherry picked from commit a80ed9f)
stigok pushed a commit to stigok/nixpkgs that referenced this pull request Jun 12, 2020
@bhipple @stigok
aliases.nix: add aliases for removed torch packages
bb3aa84 
We've removed the abandoned and broken torch project as part of NixOS#71888

This commit adds aliases for:

- NixOS#81173
- NixOS#83568

(cherry picked from commit a80ed9f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @Mic92