Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbeaver: 7.0.0 -> 7.0.1 #83195

Merged
merged 1 commit into from
Mar 23, 2020
Merged

dbeaver: 7.0.0 -> 7.0.1 #83195

merged 1 commit into from
Mar 23, 2020

Conversation

jojosch
Copy link
Member

@jojosch jojosch commented Mar 23, 2020

Motivation for this change

https://dbeaver.io/2020/03/22/dbeaver-7-0-1/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
/nix/store/sh9scx95s5fpx39wix68pzca69f22gk1-dbeaver-ce-7.0.0	 1215096440
/nix/store/hv8hz3m0ibghs8kkmcj5fl7naxg7cxy3-dbeaver-ce-7.0.1	 1215134616

Sorry, something went wrong.

@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 23, 2020
Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested, all good for me.

Could you use this PR to also quote the meta.homepage attribute? (see https://github.com/NixOS/rfcs/blob/master/rfcs/0045-deprecate-url-syntax.md)

Thanks.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
jojosch Johannes Schleifenbaum
@jojosch
Copy link
Member Author

jojosch commented Mar 23, 2020

@lsix quoted the homepage attribute.

Copy link
Member

@lsix lsix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

Thanks !!

@lsix lsix merged commit cd8e4ea into NixOS:master Mar 23, 2020
@jojosch jojosch deleted the dbeaver_7.0.1 branch March 23, 2020 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants