[WPT migration] Move align-baseline.html test from css3/flexbox to WPT #22386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 23, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2114477
branch
2 times, most recently
from
8190dbb
to
c4dc756
Compare
align-baseline.html can be migrated to WPT because it doesn't use Blink internal APIs as well as doesn't have an image baseline. Besides, the spec exists. Bug: 1063749 Change-Id: I99706d7929bc572d6fbc4b9ec0d217d7feca920d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114477 Reviewed-by: David Grogan <dgrogan@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Reviewed-by: Robert Ma <robertma@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#752688}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2114477
branch
from
c4dc756
to
6975aae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
align-baseline.html can be migrated to WPT because it doesn't use
Blink internal APIs as well as doesn't have an image baseline. Besides,
the spec exists.
Bug: 1063749
Change-Id: I99706d7929bc572d6fbc4b9ec0d217d7feca920d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2114477
Reviewed-by: David Grogan <dgrogan@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com>
Cr-Commit-Position: refs/heads/master@{#752688}