Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python38Packages.rope: disable for Python>=3.8 #83009

Merged
merged 1 commit into from Mar 23, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented Mar 20, 2020

  • browsing the github page suggests the upcoming 0.17 release should support 3.8

for ZHF: #80379

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@wd15
Copy link
Contributor

wd15 commented Mar 20, 2020

Looks like it's as at 0.16 now. Why not update?

Edit: this is for ZHF so understand why no version bump

Result of nixpkgs-review pr 83009 1

9 package marked as broken and skipped:
  • linuxPackages_hardkernel_4_14.r8125
  • linuxPackages_hardkernel_4_14.r8168
  • python38Packages.nixpkgs-pytools
  • python38Packages.pyls-isort
  • python38Packages.pyls-mypy
  • python38Packages.python-language-server
  • python38Packages.spyder
  • python38Packages.spyder_3
  • qes

@bcdarwin
Copy link
Member Author

Looks like it's as at 0.16 now. Why not update?

Result of nixpkgs-review pr 83009 1
9 package marked as broken and skipped:

@wd15 I can do that as well but the motivation for this is backporting to 20.03 so I figured a separate commit might be more efficient.

@bcdarwin
Copy link
Member Author

Also the current release (0.16) still won't build with Python 3.8

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Mar 22, 2020

@GrahamcOfBorg build python38Packages.rope python37Packages.rope

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

1 package removed:
python3.8-rope (†0.8.1)

https://github.com/NixOS/nixpkgs/pull/83009
29 package marked as broken and skipped:
clang-sierraHack-stdenv crossLibcStdenv linuxPackages-libre.sch_cake linuxPackages.sch_cake linuxPackages_4_14.sch_cake linuxPackages_4_19.sch_cake linuxPackages_4_4.sysdig linuxPackages_4_9.sysdig linuxPackages_hardened.sch_cake linuxPackages_hardkernel_4_14.r8168 linuxPackages_hardkernel_4_14.rtlwifi_new linuxPackages_hardkernel_4_14.sch_cake linuxPackages_hardkernel_4_14.sysdig linuxPackages_latest-libre.sch_cake linuxPackages_latest_hardened.sch_cake linuxPackages_latest_xen_dom0.sch_cake linuxPackages_latest_xen_dom0_hardened.sch_cake linuxPackages_testing_hardened.sch_cake linuxPackages_xen_dom0.sch_cake ocamlPackages.stog python38Packages.nixpkgs-pytools python38Packages.pyls-isort python38Packages.pyls-mypy python38Packages.python-language-server python38Packages.spyder python38Packages.spyder_3 synfigstudio telepathy-salut telepathy_salut

package broken on master

pkgs/development/python-modules/rope/default.nix Outdated Show resolved Hide resolved
- browsing the github page suggests the upcoming 0.17 release should support 3.8
@bcdarwin bcdarwin requested a review from jonringer March 23, 2020 12:41
@rnhmjoj rnhmjoj merged commit cbc3571 into NixOS:master Mar 23, 2020
@bcdarwin bcdarwin deleted the disable-python38-rope branch March 23, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants