Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.opuslib: init at 3.0.3 #83221

Merged
merged 2 commits into from Mar 23, 2020
Merged

python3Packages.opuslib: init at 3.0.3 #83221

merged 2 commits into from Mar 23, 2020

Conversation

thelegy
Copy link
Member

@thelegy thelegy commented Mar 23, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@thelegy thelegy force-pushed the python3Packages.opuslib branch 2 times, most recently from 2325409 to 05e760f Compare March 23, 2020 15:58
jonringer
jonringer reviewed Mar 23, 2020
View reviewed changes
maintainers/maintainer-list.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/opuslib/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/python-packages.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/opuslib/default.nix Show resolved Hide resolved
jonringer
jonringer approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commits LGTM
has tests 👍

https://github.com/NixOS/nixpkgs/pull/83221
11 package marked as broken and skipped:
linuxPackages_hardkernel_4_14.prl-tools php72Packages-unit.php_excel php72Packages.php_excel php73Packages-unit.php_excel php73Packages.php_excel php74Packages-unit.couchbase php74Packages-unit.pcs php74Packages-unit.php_excel php74Packages.couchbase php74Packages.pcs php74Packages.php_excel

2 package built:
python37Packages.opuslib python38Packages.opuslib

@jonringer
Copy link
Contributor

going to wait for ofborg to eval, and then merge

@jonringer
Copy link
Contributor

@thelegy congrats on your first addition to nixpkgs :)

@jonringer jonringer merged commit ca3e516 into NixOS:master Mar 23, 2020
@thelegy
Copy link
Member Author

thelegy commented Mar 23, 2020

thanks

@thelegy thelegy deleted the python3Packages.opuslib branch March 23, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thelegy @jonringer @Janik-Haag