Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux-libre: added --force flag for deblobbing. #83220

Merged
merged 1 commit into from Mar 29, 2020
Merged

linux-libre: added --force flag for deblobbing. #83220

merged 1 commit into from Mar 29, 2020

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented Mar 23, 2020

Motivation for this change

After the latest update, linux-libre failed to compile because there were files which got emptied by the deblobbing script. Therefore I added the --force flag. I hope this does not have undesired side-effects.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    CC: @alyssais

@Mic92 Mic92 requested a review from alyssais March 29, 2020 14:03
@Mic92 Mic92 merged commit ac45e96 into NixOS:master Mar 29, 2020
@dasj19
Copy link
Contributor Author

dasj19 commented Mar 29, 2020

Hi I was just about to perform a nixpkgs-review and I got the following results:

18 package marked as broken and skipped:
linuxPackages-libre.cryptodev linuxPackages-libre.ixgbevf linuxPackages-libre.lttng-modules linuxPackages-libre.nvidia_x11_legacy304 linuxPackages-libre.openafs linuxPackages-libre.phc-intel linuxPackages-libre.rtl8723bs linuxPackages-libre.sch_cake linuxPackages-libre.tbs linuxPackages_latest-libre.cryptodev linuxPackages_latest-libre.ixgbevf linuxPackages_latest-libre.lttng-modules linuxPackages_latest-libre.nvidia_x11_legacy304 linuxPackages_latest-libre.openafs linuxPackages_latest-libre.phc-intel linuxPackages_latest-libre.rtl8723bs linuxPackages_latest-libre.sch_cake linuxPackages_latest-libre.tbs

25 package failed to build:
linuxPackages-libre.amdgpu-pro linuxPackages-libre.can-isotp linuxPackages-libre.jool linuxPackages-libre.mwprocapture linuxPackages-libre.mxu11x0 linuxPackages-libre.ndiswrapper linuxPackages-libre.nvidia_x11_legacy340 linuxPackages-libre.r8168 linuxPackages-libre.rtl8814au linuxPackages-libre.rtl8821au linuxPackages-libre.rtl8821ce linuxPackages_latest-libre.amdgpu-pro linuxPackages_latest-libre.batman_adv linuxPackages_latest-libre.can-isotp linuxPackages_latest-libre.jool linuxPackages_latest-libre.mwprocapture linuxPackages_latest-libre.mxu11x0 linuxPackages_latest-libre.ndiswrapper linuxPackages_latest-libre.netatop linuxPackages_latest-libre.nvidia_x11_legacy340 linuxPackages_latest-libre.nvidia_x11_legacy390 linuxPackages_latest-libre.r8168 linuxPackages_latest-libre.rtl8814au linuxPackages_latest-libre.rtl8821au linuxPackages_latest-libre.rtl8821ce

101 package built:
linux-libre linuxPackages-libre.acpi_call linuxPackages-libre.anbox linuxPackages-libre.asus-wmi-sensors linuxPackages-libre.batman_adv linuxPackages-libre.bbswitch linuxPackages-libre.bcc linuxPackages-libre.bpftrace linuxPackages-libre.broadcom_sta linuxPackages-libre.chipsec linuxPackages-libre.cpupower linuxPackages-libre.ddcci-driver linuxPackages-libre.deepin-anything linuxPackages-libre.digimend linuxPackages-libre.dpdk linuxPackages-libre.ena linuxPackages-libre.evdi linuxPackages-libre.exfat-nofuse linuxPackages-libre.facetimehd linuxPackages-libre.fwts-efi-runtime linuxPackages-libre.hyperv-daemons linuxPackages-libre.intel-speed-select linuxPackages-libre.it87 linuxPackages-libre.mba6x_bl linuxPackages-libre.netatop linuxPackages-libre.nvidia_x11 linuxPackages-libre.nvidia_x11_legacy390 linuxPackages-libre.nvidiabl linuxPackages-libre.openafs_1_8 linuxPackages-libre.openrazer linuxPackages-libre.perf linuxPackages-libre.ply linuxPackages-libre.r8125 linuxPackages-libre.rtl8192eu linuxPackages-libre.rtl8812au linuxPackages-libre.rtlwifi_new linuxPackages-libre.sysdig linuxPackages-libre.systemtap linuxPackages-libre.tmon linuxPackages-libre.tp_smapi linuxPackages-libre.turbostat linuxPackages-libre.tuxedo-keyboard linuxPackages-libre.usbip linuxPackages-libre.v4l2loopback linuxPackages-libre.v86d linuxPackages-libre.vhba linuxPackages-libre.virtualbox linuxPackages-libre.virtualboxGuestAdditions linuxPackages-libre.wireguard linuxPackages-libre.x86_energy_perf_policy linuxPackages-libre.zenpower linuxPackages-libre.zfs linuxPackages_latest-libre.acpi_call linuxPackages_latest-libre.anbox linuxPackages_latest-libre.asus-wmi-sensors linuxPackages_latest-libre.bbswitch linuxPackages_latest-libre.bcc linuxPackages_latest-libre.bpftrace linuxPackages_latest-libre.broadcom_sta linuxPackages_latest-libre.chipsec linuxPackages_latest-libre.cpupower linuxPackages_latest-libre.ddcci-driver linuxPackages_latest-libre.deepin-anything linuxPackages_latest-libre.digimend linuxPackages_latest-libre.dpdk linuxPackages_latest-libre.ena linuxPackages_latest-libre.evdi linuxPackages_latest-libre.exfat-nofuse linuxPackages_latest-libre.facetimehd linuxPackages_latest-libre.fwts-efi-runtime linuxPackages_latest-libre.hyperv-daemons linuxPackages_latest-libre.intel-speed-select linuxPackages_latest-libre.it87 linux_latest-libre linuxPackages_latest-libre.mba6x_bl linuxPackages_latest-libre.nvidia_x11 linuxPackages_latest-libre.nvidiabl linuxPackages_latest-libre.openafs_1_8 linuxPackages_latest-libre.openrazer linuxPackages_latest-libre.perf linuxPackages_latest-libre.ply linuxPackages_latest-libre.r8125 linuxPackages_latest-libre.rtl8192eu linuxPackages_latest-libre.rtl8812au linuxPackages_latest-libre.rtlwifi_new linuxPackages_latest-libre.sysdig linuxPackages_latest-libre.systemtap linuxPackages_latest-libre.tmon linuxPackages_latest-libre.tp_smapi linuxPackages_latest-libre.turbostat linuxPackages_latest-libre.tuxedo-keyboard linuxPackages_latest-libre.usbip linuxPackages_latest-libre.v4l2loopback linuxPackages_latest-libre.v86d linuxPackages_latest-libre.vhba linuxPackages_latest-libre.virtualbox linuxPackages_latest-libre.virtualboxGuestAdditions linuxPackages_latest-libre.wireguard linuxPackages_latest-libre.x86_energy_perf_policy linuxPackages_latest-libre.zenpower linuxPackages_latest-libre.zfs

I am a bit unclear why it tried to build broken packages...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssais alyssais Awaiting requested review from alyssais

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasj19 @Mic92