Add STAT table, fix name IDs, suppress font-synthesis, add fvar instance #22392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Concluding from the discussion in web-platform-tests#22355 name ids should have values greater than 255, and the font should have a STAT table. The name id issue is something the Firefox prints out as an error on the command line. Add a STAT table, add a named instance for the regular instance, and move name ids in this change. Also add encoding headers in tests and references, and suppress font-synthesis as this is needed to help the test pass on Firefox. Fixes web-platform-tests#22355 for Firefox.
drott
changed the title
|
CC @jfkthame - this should be sufficient to make it pass in Firefox, I assume? Thanks for your review. |
|
Yes, LGTM. |
|
CC @kojiishi - can you LGTM WPT changes, too? |
litherum
approved these changes
Mar 24, 2020
|
Thanks for the quick review, Myles! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concluding from the discussion in #22355 name ids should have values
greater than 255, and the font should have a STAT table. The name id
issue is something the Firefox prints out as an error on the command
line. Add a STAT table, add a named instance for the regular instance,
and move name ids in this change. Also add encoding headers in tests and
references, and suppress font-synthesis as this is needed to help the
test pass on Firefox.
Fixes #22355 for Firefox.