Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

visidata: add setuptools #83214

Merged
merged 1 commit into from Mar 23, 2020
Merged

visidata: add setuptools #83214

merged 1 commit into from Mar 23, 2020

Conversation

teto
Copy link
Member

@teto teto commented Mar 23, 2020 •
edited

and ran nixpkgs-fmt.

This allows to access visidata's help via ctrl+H since right now this results in:
ModuleNotFoundError: No module named 'pkg_resources'

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
visidata: add setuptools
a1c763e 
and ran nixpkgs-fmt.

This allows to access visidata's help via ctrl+H.
@ofborg ofborg bot requested a review from 7c6f434c March 23, 2020 13:40
@7c6f434c
Copy link
Member

Of course the reformatting makes the real change hard to see…

@teto teto merged commit d21cf30 into NixOS:master Mar 23, 2020
@teto teto deleted the visidata branch March 23, 2020 19:50
@teto
Copy link
Member Author

teto commented Mar 23, 2020

Yeah I hesitated, I just added 2 setuptools words.

@7c6f434c
Copy link
Member

I said hard, not impossible! I guess splitting the commits could help (… to sneak a hidden change, mwahaha)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @7c6f434c