Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pymavlink: 2.4.3 -> 2.4.6 #83227

Merged
merged 1 commit into from Mar 23, 2020
Merged

pythonPackages.pymavlink: 2.4.3 -> 2.4.6 #83227

merged 1 commit into from Mar 23, 2020

Conversation

lopsided98
Copy link
Contributor

Motivation for this change

Updates pymavlink to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

[14 built, 8 copied (1.7 MiB), 0.4 MiB DL]
https://github.com/NixOS/nixpkgs/pull/83227
4 package built:
mavproxy python27Packages.pymavlink python37Packages.pymavlink python38Packages.pymavlink

@jonringer jonringer merged commit eb24f9e into NixOS:master Mar 23, 2020
@lopsided98 lopsided98 deleted the pymavlink-update branch March 23, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lopsided98 @jonringer