Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tailscale: switch version and git ref to use a tag. #83238

Merged
merged 1 commit into from Mar 23, 2020
Merged

tailscale: switch version and git ref to use a tag. #83238

merged 1 commit into from Mar 23, 2020

Conversation

danderson
Copy link
Contributor

Motivation for this change

As requested, cc @Profpatsch @worldofpeace .

The tag points to the same commit hash as in the previous config, so the output binaries are unchanged.

Signed-off-by: David Anderson dave@natulte.net

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danderson
tailscale: switch version and git ref to use a tag.
3fa813e 
The tag points to the same commit hash, so the binary
is unchanged.

Signed-off-by: David Anderson <dave@natulte.net>
@worldofpeace
Copy link
Contributor

Just waiting for checks ⏲️

@ofborg ofborg bot requested review from martinbaillie and kalbasit March 23, 2020 19:22
@worldofpeace worldofpeace merged commit d7da377 into NixOS:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinbaillie martinbaillie Awaiting requested review from martinbaillie

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danderson @worldofpeace