Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retroarch: fix picodrive on aarch64 #83240

Merged
merged 1 commit into from Mar 23, 2020
Merged

retroarch: fix picodrive on aarch64 #83240

merged 1 commit into from Mar 23, 2020

Conversation

kolbycrouch
Copy link

Motivation for this change

picodrive doesn't build right now on aarch64-linux.

Things done

adjusts makeFlags to get it working on aarch64-linux.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from edwtjo, hrdinka and MP2E March 23, 2020 19:29
@matthewbauer matthewbauer merged commit 11f8bb7 into NixOS:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo

@hrdinka hrdinka Awaiting requested review from hrdinka

@MP2E MP2E Awaiting requested review from MP2E

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kolbycrouch @matthewbauer @WayaOS