Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meshlab: 20190129-beta -> 2020.03 #83302

Merged
merged 1 commit into from Jul 21, 2020
Merged

meshlab: 20190129-beta -> 2020.03 #83302

merged 1 commit into from Jul 21, 2020

Conversation

chpatrick
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from viric March 24, 2020 16:42
nh2
nh2 reviewed Mar 26, 2020
View reviewed changes
Copy link
Contributor

@nh2 nh2 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement overall with the new version. Builds and runs.

But somehow this update is losing the version information, showing MeshLab 1970.01 in the title bar and about screen:

image

pkgs/applications/graphics/meshlab/default.nix Outdated Show resolved Hide resolved
@nh2
Copy link
Contributor

nh2 commented Mar 26, 2020

But somehow this update is losing the version information

I found the reason: cnr-isti-vclab/meshlab#622

@chpatrick chpatrick force-pushed the meshlab-20.03 branch 3 times, most recently from 1472baa to 22d93f2 Compare March 26, 2020 21:21
@nh2
Copy link
Contributor

nh2 commented Mar 28, 2020

I found the reason: cnr-isti-vclab/meshlab#622

Upstream fix: cnr-isti-vclab/meshlab#625

@raboof
Copy link
Member

raboof commented Jul 20, 2020

2020.07 has been released since, which includes the upstream fix mentioned above.

I tried adapting this PR to 2020.07, raboof@9295927 - which can now be a bit simpler, but unfortunately libmeshlab-common.so is not correctly linked. I guess this needs a patchelf invocation somewhere, but I'm not sure where exactly.

@nh2
Copy link
Contributor

nh2 commented Jul 21, 2020

@raboof I'll merge this PR now so that we get some progress, as this version works well for us, please open another PR (you can make it a draft one if it doesn't work yet so we can iterate on it).

One feedback/request so far: Can you, in the commit message, point out for each removed patch where/how it was made unnecessary? Especially for the 3 Archlinux patches, as they don't link to upstream issues so it's not so easy to check.

@nh2 nh2 merged commit 2f3bec7 into NixOS:master Jul 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nh2 nh2 nh2 left review comments

@viric viric Awaiting requested review from viric

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chpatrick @nh2 @raboof