UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers #22420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Mar 24, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2117591
branch
from
f69f12d
to
b5657e4
Compare
|
The following tests are flaky on Chrome Dev.
|
|
@elkurin Would you mind taking a quick look? Let me know if you need help reproducing it locally! |
|
@nhiroki Could you check this? Thanks! |
|
Added a ping in the originating CL. |
|
OK, I'll take a look. |
…d workers This CL adds upgrade-insecure-request wpts to test static-import from dedicated workers and shared workers. The test scheme is implemented in the previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2102036. This CL only removes 'worker-import' and 'sharedworker-import' from the excluded subresource list in spec.src.json and auto-generates tests. Bug: 989399 Change-Id: I3b799d7743306a8b5fca0d7292360a88d9b36ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117591 Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Eriko Kurimoto <elkurin@google.com> Cr-Commit-Position: refs/heads/master@{#753164}
foolip
force-pushed
the
chromium-export-cl-2117591
branch
from
b5657e4
to
5179406
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds upgrade-insecure-request wpts to test static-import from
dedicated workers and shared workers.
The test scheme is implemented in the previous CL:
https://chromium-review.googlesource.com/c/chromium/src/+/2102036.
This CL only removes 'worker-import' and 'sharedworker-import' from
the excluded subresource list in spec.src.json and auto-generates tests.
Bug: 989399
Change-Id: I3b799d7743306a8b5fca0d7292360a88d9b36ded
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117591
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Cr-Commit-Position: refs/heads/master@{#753164}