Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tuptime: Init Package, Module and Test #83301

Merged
merged 3 commits into from Apr 19, 2020
Merged

Tuptime: Init Package, Module and Test #83301

merged 3 commits into from Apr 19, 2020

Conversation

evils
Copy link
Member

@evils evils commented Mar 24, 2020

Motivation for this change

NixOS currently does not offer anything comparable (uptime and downtime tracking / reporting)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
    • 106198976
    • du -hs $(readlink result): 64K
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evils evils requested a review from infinisil as a code owner March 24, 2020 16:30
@evils evils changed the title Tuptime: Init Package, Module and Test [WIP] Tuptime: Init Package, Module and Test Mar 24, 2020
aanderse
aanderse requested changes Mar 24, 2020
View reviewed changes
nixos/modules/services/monitoring/tuptime.nix Outdated Show resolved Hide resolved
nixos/modules/services/monitoring/tuptime.nix Outdated Show resolved Hide resolved
@evils evils requested a review from aanderse March 25, 2020 00:15
@evils evils changed the title [WIP] Tuptime: Init Package, Module and Test Tuptime: Init Package, Module and Test Mar 25, 2020
@evils
Copy link
Member Author

evils commented Apr 2, 2020 •
edited

@aanderse i applied your suggested change, though github is somehow showing this PR with "changes requested" for non-existent code, can you clear that?

aanderse
aanderse requested changes Apr 2, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flokli @arianvp any suggestions on the systemd services and timers?

nixos/modules/services/monitoring/tuptime.nix Show resolved Hide resolved
@flokli
Copy link
Contributor

flokli commented Apr 2, 2020

@GrahamcOfBorg test tuptime

flokli
flokli requested changes Apr 3, 2020
View reviewed changes
Copy link
Contributor

@flokli flokli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err… wait.
The module commit message should probably be nixos/tuptime: init module, and the test nixosTests.tuptime: init test.

@evils
Copy link
Member Author

evils commented Apr 3, 2020

The module commit message should probably be nixos/tuptime: init module, and the test nixosTests.tuptime: init test.

done, thanks

@evils evils requested a review from flokli April 19, 2020 19:25
@flokli flokli merged commit a88d17b into NixOS:master Apr 19, 2020
@flokli
Copy link
Contributor

flokli commented Apr 19, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arianvp arianvp arianvp left review comments

@aanderse aanderse aanderse requested changes

@infinisil infinisil Awaiting requested review from infinisil

@flokli flokli Awaiting requested review from flokli

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@evils @flokli @arianvp @aanderse