Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/sympa: fix outgoing emails, update package version #83258

Merged
merged 3 commits into from Apr 2, 2020
Merged

nixos/sympa: fix outgoing emails, update package version #83258

merged 3 commits into from Apr 2, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Mar 24, 2020 •
edited

Motivation for this change
  • The service has not been able to actually send emails because systemd sandboxing didn't allow it to call sendmail setgid wrapper. I probably broke it during the later iterations of sympa: init at 6.2.52 + NixOS module #65397 and haven't caught it until now. Shame on me.
  • New version contains various bugfixes, including CVE-2020-9369.
  • The --enable-fhs configure flag makes the resulting package layout saner, e.g. by not installing perl modules into $out/bin. Upstream plans to make this the default eventually.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmilata
sympa: 6.2.52 -> 6.2.54
adc7388
@mmilata
sympa: build with --enable-fhs
8f632b4 
Update module accordingly.
@mmilata
nixos/sympa: fix outgoing messaging
fdc36e2 
Because ProtectKernelModules implies NoNewPrivileges, postfix's sendmail
executable, which is setgid, wasn't able to send mail.
@ofborg ofborg bot requested a review from sorki March 24, 2020 01:51
@infinisil
Copy link
Member

@GrahamcOfBorg test sympa

@infinisil infinisil merged commit c06bcdd into NixOS:master Apr 2, 2020
@mmilata mmilata mentioned this pull request Apr 3, 2020
Merged
10 tasks
@mmilata mmilata deleted the sympa-6.2.54 branch April 3, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorki sorki Awaiting requested review from sorki

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmilata @infinisil