Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.varint: init at 1.0.2 #83197

Merged
merged 1 commit into from
Apr 9, 2020
Merged

pythonPackages.varint: init at 1.0.2 #83197

merged 1 commit into from
Apr 9, 2020
+27 −0

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Mar 23, 2020 •
edited
Loading

Motivation for this change

This is needed for adding py-multihash package. #83203

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@ofborg ofborg bot added 6.topic: python 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 23, 2020
@Rakesh4G Rakesh4G mentioned this pull request Mar 23, 2020
Merged
10 tasks
jonringer
jonringer reviewed Mar 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit-pick: typo in commit message: pyhton -> python

@Rakesh4G Rakesh4G changed the title pyhtonPackages.varint: init at 1.0.2 pythonPackages.varint: init at 1.0.2 Mar 24, 2020
@Rakesh4G
Copy link
Contributor Author

Nit-pick: typo in commit message: pyhton -> python
Hi @jonringer
done. Thanks.
For future i will also try to use nitpick offline before pushing.

@wd15
Copy link
Contributor

wd15 commented Mar 24, 2020

Does this package have any tests?

Result of nixpkgs-review pr 83197 1

3 package built:
  • python27Packages.varint
  • python37Packages.varint
  • python38Packages.varint

@FRidh
Copy link
Member

FRidh commented Mar 29, 2020

@GrahamcOfBorg build python3Packages.varint

@FRidh
Copy link
Member

FRidh commented Mar 29, 2020 

Ran 0 tests in 0.000s

No tests are found. Either the test runner cannot find tests and needs to be patched, or there simply are no tests in which case the tests need to be disabled. Do include a comment explaining why the tests are disabled.

FRidh
FRidh requested changes Mar 29, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests

@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label Apr 1, 2020
@Rakesh4G Rakesh4G requested a review from FRidh April 1, 2020 09:32
@Rakesh4G
Copy link
Contributor Author

Rakesh4G commented Apr 1, 2020

tests

@FRidh , I have disabled the check Phase as there are no tests. Also added pythonImportsCheck.
Thanks.

@grahamc grahamc removed the ofborg-internal-error Ofborg encountered an error label Apr 2, 2020
jonringer
jonringer reviewed Apr 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for readability

@Rakesh4G
Copy link
Contributor Author

Rakesh4G commented Apr 9, 2020

Hi @jonringer , I have updated as suggested. Thanks.

jonringer
jonringer approved these changes Apr 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 83197 1

3 packages built: - python27Packages.varint - python37Packages.varint - python38Packages.varint

@jonringer jonringer merged commit 6a6cb2b into NixOS:master Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

@FRidh FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Rakesh4G @wd15 @FRidh @jonringer @grahamc