Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

citra: 2019-10-05 -> 2020-03-21 #83193

Merged
merged 1 commit into from Apr 10, 2020
Merged

citra: 2019-10-05 -> 2020-03-21 #83193

merged 1 commit into from Apr 10, 2020
+5 −5

Conversation

JoshuaFern
Copy link
Member

@JoshuaFern JoshuaFern commented Mar 23, 2020 •
edited

Motivation for this change

Version bump, also fixes the common qt xcb plugin error

Note: Audio seems to require sdl2 to be selected (nothing new, also true in the previous version)

@abbradar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@JoshuaFern
citra: 2019-10-05 -> 2020-03-21
83616f1 
Version bump, also fixes the common qt xcb plugin error
@ofborg ofborg bot requested a review from abbradar March 23, 2020 09:07
@IvarWithoutBones
Copy link
Member

The Could not find the Qt platform plugin "xcb" in "" problem still occurs on nixos-unstable.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 9, 2020

There is another PR (#83758) with a newer revision but, sadly, equally broken. You may want to join the efforts and/or close this one.

@JoshuaFern
Copy link
Member Author

The Could not find the Qt platform plugin "xcb" in "" problem still occurs on nixos-unstable.

I'm using nixos-unstable and it works fine here :/

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 9, 2020

@JoshuaFern you probably have inpurities from your environment. Are you running KDE or some other DE, by any chance? Try running the program within nix-shell --pure.

@JoshuaFern
Copy link
Member Author

JoshuaFern commented Apr 9, 2020 •
edited

@JoshuaFern you probably have inpurities from your environment. Are you running KDE or some other DE, by any chance?

Just i3wm

Try running the program within nix-shell --pure.

Sure, still seems to run fine.

nixos-workstation% nix-shell --pure -p citra -I nixpkgs=https://github.com/JoshuaFern/nixpkgs/archive/83616f1bc50b9727b5c7d0ff60e063dbdd5d5a92.tar.gz
unpacking 'https://github.com/JoshuaFern/nixpkgs/archive/83616f1bc50b9727b5c7d0ff60e063dbdd5d5a92.tar.gz'...
these paths will be fetched (0.05 MiB download, 0.28 MiB unpacked):
  /nix/store/m8czkhz4abcz367scm8a429agyyp1f06-bash-interactive-4.4-p23-dev
copying path '/nix/store/m8czkhz4abcz367scm8a429agyyp1f06-bash-interactive-4.4-p23-dev' from 'https://cache.nixos.org'...

[nix-shell:~/git/nixpkgs]$ citra-qt
QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/run/user/1000/runtime-jdf'

Let me know if I ran it correctly.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 9, 2020

Oh, sorry. I didn't notice the mkDerivation plus when I tried starting it I had the wrong DISPLAY variable set. Yes, it does work, not sure about @IvarWithoutBones.

@JoshuaFern
Copy link
Member Author

I'm going to leave this open for now, it's currently in better shape than the newer PR.

@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 9, 2020

Would update it to the latest revision in master or do you see no point in this?
In any case it looks already good to go.

@JoshuaFern
Copy link
Member Author

JoshuaFern commented Apr 9, 2020 •
edited

Would update it to the latest revision in master or do you see no point in this?

I've been using this version for the past 18 days and it seems stable from my own anecdotal experience, whatever that's worth.

@rnhmjoj rnhmjoj mentioned this pull request Apr 10, 2020
Closed
10 tasks
@rnhmjoj rnhmjoj merged commit f1addf3 into NixOS:master Apr 10, 2020
@JoshuaFern JoshuaFern deleted the patch-2 branch April 10, 2020 14:07
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Apr 10, 2020

Backported to 20.03 in f35b2f2.

@JoshuaFern JoshuaFern mentioned this pull request Sep 4, 2021
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JoshuaFern @IvarWithoutBones @rnhmjoj